Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HotFix] Fix crash when launching magic link screen on API < 23 #7725

Merged
merged 1 commit into from Nov 2, 2022
Merged

[HotFix] Fix crash when launching magic link screen on API < 23 #7725

merged 1 commit into from Nov 2, 2022

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Nov 2, 2022 •
edited

Closes: #7608

Description

This PR fixes a crash that occurred on devices with API < 24 in the Magic Link screen.

Testing instructions

  1. Please use a device with API < 24 (Lollipop or Marshmallow).
  2. Open the app.
  3. Enter your WordPress.com email (shouldn't be an Automattic email).
  4. Click on "Log in with magic link"
  5. Confirm the app doesn't crash.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hichamboushaba hichamboushaba added type: crash The worst kind of bug. feature: login Related to any part of the log in or sign in flow, or authentication. labels Nov 2, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 2, 2022 •
edited

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

@hichamboushaba hichamboushaba mentioned this pull request Nov 2, 2022
Merged
@hichamboushaba hichamboushaba changed the title Attempt to fix crash in magic link screen for API < 23 [HotFix] Fix crash when launching magic link screen on API < 23 Nov 2, 2022
malinajirka
malinajirka approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hichamboushaba ! I'm approving the PR since I've tested it and verified it doesn't contain any unexpected changes for hotfix in 10.9. I'm approving it since I have two calls in the next two hours and I don't want to delay the hotfix. LGTM - as long as we update the version reference.

@hichamboushaba hichamboushaba changed the base branch from trunk to release/10.9.1 November 2, 2022 15:16
@hichamboushaba hichamboushaba marked this pull request as ready for review November 2, 2022 15:17
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 2, 2022 •
edited

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@hichamboushaba hichamboushaba added this to the 10.9 milestone Nov 2, 2022
@wpmobilebot
Copy link
Collaborator

Found 1 violations:

The PR caused the following dependency changes:

expand 

-\--- org.wordpress:login:0.20.0
+\--- org.wordpress:login:0.21.0

Please review and act accordingly

@hichamboushaba hichamboushaba merged commit dc44e6b into release/10.9.1 Nov 2, 2022
@hichamboushaba hichamboushaba deleted the issue/7608-login-crash-API-23 branch November 2, 2022 16:31
@spencertransier spencertransier mentioned this pull request Nov 2, 2022
Merged
@malinajirka malinajirka mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinajirka malinajirka malinajirka approved these changes

Assignees
No one assigned
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: crash The worst kind of bug.
Projects
None yet
Milestone
10.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hichamboushaba @wpmobilebot @malinajirka