Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Adjust the padding of the Banner pattern #10103

Closed
Tracked by #42339
nielslange opened this issue Jul 5, 2023 · 0 comments · Fixed by #10107
Closed
Tracked by #42339

Adjust the padding of the Banner pattern #10103

nielslange opened this issue Jul 5, 2023 · 0 comments · Fixed by #10107
Assignees
Labels
focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.

Comments

@nielslange
Copy link
Member

Note

In #9877, we improved spacing and centring for mobile devices. While testing the WooCommerce Blocks 10.6.0 release, I noticed that the current padding leads to a very narrow text section when viewing the Banner pattern on a mobile device. This issue aims to decrease the padding to prevent that the user has to scroll too much because of a text that is displayed too narrow.

Expected behaviour

I expect the padding to be smaller so that I can see more text and don't have to scroll too much.

Current behaviour

Currently, there's too much left and right padding leading to a narrow text and forcing the user to scroll more.

Steps to reproduce

  1. Create a test page.
  2. Add the Banner pattern to it.
  3. Switch the preview to Mobile.
  4. See that the text is very narrow.

Proposed solution

I propose changing the left and right padding from 4 to 1 as seen in the screenshot below.

Screenshot

Current behaviour (left- and right padding of 4)

Screenshot 2023-07-05 at 12 31 11

Proposed behaviour (left- and right padding of 1)

Screenshot 2023-07-05 at 12 31 34

cc: @albarin (internal thread: p1688562657170209/1688552807.622379-slack-C02UBB1EPEF)

@nielslange nielslange added type: enhancement The issue is a request for an enhancement. focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns labels Jul 5, 2023
@danielwrobert danielwrobert self-assigned this Jul 6, 2023
danielwrobert added a commit that referenced this issue Jul 6, 2023
As suggested in #10103, this new alignment setting strikes a better
balance on both mobile and desktop views.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: global styles Issues that involve styles/css/layout structure. focus: patterns WooCommerce patterns type: enhancement The issue is a request for an enhancement.
Projects
None yet
2 participants