This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Adjust Banner
padding to improve mobile experience
#10107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
type: enhancement
The issue is a request for an enhancement.
focus: global styles
Issues that involve styles/css/layout structure.
focus: patterns
WooCommerce patterns
labels
Jul 6, 2023
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
July 6, 2023 08:04
The release ZIP for this PR is accessible via:
Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Size Change: 0 B Total Size: 1.35 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @albarin!
4 tasks
I'm adding this PR to the current milestone for the release 10.7.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: global styles
Issues that involve styles/css/layout structure.
focus: patterns
WooCommerce patterns
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs modifies the padding of the
Banner
pattern to improve the look in mobile.Fixes #10103
Screenshots
Testing
User Facing Testing
Banner
pattern to it.Mobile
.WooCommerce Visibility
Changelog