Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Display view switcher for Cart Block when selecting inner blocks #6985

Closed
tarunvijwani opened this issue Aug 25, 2022 · 2 comments · Fixed by #8006
Closed

Display view switcher for Cart Block when selecting inner blocks #6985

tarunvijwani opened this issue Aug 25, 2022 · 2 comments · Fixed by #8006
Assignees
@mikejolley
Labels
block: cart Issues related to the cart block. status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: bug The issue/PR concerns a confirmed bug.

Comments

@tarunvijwani
Copy link
Contributor

Describe the bug

__experimentalExposeControlsToChildren was added by the PR to display the view switcher when selecting the inner blocks of the Cart block. It was dependent on PR opened in Gutenberg repo, which was never merged.

Currently, the view switcher is only visible when we select the parent Cart block, which is nearly impossible to select without using the list view option. It can be done now using a filter.

To reproduce

Steps to reproduce the behavior:

  1. Go to Cart block.
  2. Click on any inner block
  3. Notice there is no option to select view switcher

Expected behavior

View switcher should be displayed when selecting inner blocks
@tarunvijwani tarunvijwani added type: bug The issue/PR concerns a confirmed bug. block: cart Issues related to the cart block. labels Aug 25, 2022
@ralucaStan
Copy link
Contributor

Related to #6698

@tarunvijwani tarunvijwani self-assigned this Sep 15, 2022
@tarunvijwani tarunvijwani mentioned this issue Oct 12, 2022
Closed
14 tasks
@tarunvijwani tarunvijwani removed their assignment Oct 28, 2022
@tarunvijwani
Copy link
Contributor Author

Marking this issue on hold for further discussion: pca54o-4DS-p2

@tarunvijwani tarunvijwani added the status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). label Nov 30, 2022
@mikejolley mikejolley self-assigned this Dec 20, 2022
@mikejolley mikejolley mentioned this issue Dec 21, 2022
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikejolley mikejolley

Labels
block: cart Issues related to the cart block. status: on hold The issue is currently not prioritized or is awaiting something (for example, a fix upsteam). type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
No milestone
3 participants
@mikejolley @ralucaStan @tarunvijwani