This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Cart i2: view switcher shared to children #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
skip-changelog
|
Size Change: +52 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Sep 23, 2021
Comment on lines
159
to
165
| { | ||
| view: 'filledCart', | ||
| label: __( 'Filled Cart', 'woo-gutenberg-products-block' ), | ||
| icon: <Icon srcElement={ filledCart } />, | ||
| default: true, | ||
| }, | ||
| ] |
There was a problem hiding this comment.
Nitpick, given this is the default option, can it be the first one? When opening the switcher, the first item is focused, It makes it confusing because emptyCart is focused and looks like it's selected.
| title: view.label, | ||
| onClick: () => { | ||
| setCurrentView( view ); | ||
| selectBlock( clientId ); |
There was a problem hiding this comment.
Can we not select the parent Cart block and just select the current one? So, filled or empty cart block?
There was a problem hiding this comment.
How will we get the client ID?
There was a problem hiding this comment.
selectBlock( getBlock( clientId ).innerBlocks.find(block => block.name === 'woocommerce/filled-cart-block').clientId )
But like prettier and not a single line.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Do you want me to pick up this issue @mikejolley ? |
|
@senadir nah Ill wrap it up soon. |
mikejolley
force-pushed
the
add/view-switcher-experimental-share
branch
from
a9ee915
to
df53745
Compare
|
@senadir do you want a final look? I made those changes and simplified the API a bit so we map view -> block Name. Makes selection easier too. |
senadir
approved these changes
Sep 24, 2021
This was referenced Aug 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
__experimentalExposeToChildrenso that the view switcher is passed down to all children toolbars. When switching, the view is changed and the parent is selected to avoid the selection of a non-visible block.Fixes #4812
NOTE: Only the top 2 levels of inner blocks will show the toolbar item, unless you first implement WordPress/gutenberg#35078 This makes it so all levels show the toolbar item.
How to test the changes in this Pull Request: