This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add filter for place order button label #7154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: +96 B (0%) Total Size: 916 kB
ℹ️ View Unchanged
|
….com:woocommerce/woocommerce-blocks into add/5876-add-place-order-button-label-filter # Conflicts: # assets/js/base/context/hooks/use-checkout-submit.js
nielslange
changed the title
nielslange
added
status: needs review
type: enhancement
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
opr
suggested changes
Sep 16, 2022
docs/third-party-developers/extensibility/checkout-block/available-filters.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/checkout-block/available-filters.md
Show resolved
Hide resolved
…able-filters.md Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
….com:woocommerce/woocommerce-blocks into add/5876-add-place-order-button-label-filter # Conflicts: # docs/third-party-developers/extensibility/checkout-block/available-filters.md
There was a problem hiding this comment.
Great work @nielslange, just a minor suggestion and a question. I like the way you took the initiative to correct some of the documentation formatting errors, thanks for that!
Co-authored-by: Alex Florisca <alex.florisca@automattic.com>
Thanks for your review. I see that @senadir already answered the question, and I've committed your suggestion. Do you want to give it another review? |
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
senadir
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* WIP add filter for place order button label * Solve TS issue * Add display priority * Refactor display priority * WIP Implement useMemo() * Try using a global cache * Add docs for placeOrderLabel filter * Update docs/third-party-developers/extensibility/checkout-block/available-filters.md Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> * Adjust docs * Rename “placeOrderLabel” to “placeOrderButtonLabel” * Update assets/js/types/type-defs/payments.ts Co-authored-by: Alex Florisca <alex.florisca@automattic.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Alex Florisca <alex.florisca@automattic.com> Co-authored-by: Lucio Giannotta <lucio.giannotta@a8c.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5876
Note
Currently, the
Place Orderbutton either showsPlace Orderor the payment method label, e.g.Proceed to PayPal. However, it's not possible for a merchant to change the button label. This PR aims to add a filter to thePlace Orderbutton so that a merchant can change the label if needed.While testing this PR with multiple payment method, I noticed that
__experimentalRegisterCheckoutFilterswas returning the same result for all payment methods. In p1663160361460549-slack-C8X6Q7XQ, I reached out to @senadir who updated the caching mechanism of packages/checkout/filter-registry/index.ts. This update is also part of this PR.Testing
Verify that label filter works
/wp-admin/edit.php?post_type=custom-css-jsand add the following JS code snippet:Pay now.Verify that payment method label still works.
/wp-admin/admin.php?page=snippetsand add the following PHP code snippet:/wp-admin/admin.php?page=wc-settings&tab=checkout§ion=paypaland select the optionsEnable PayPal StandardandEnable PayPal sandbox.PayPal.Proceed to PayPal.Verify that default label still works.
PayPal, e.g.Credit Card (Stripe).Place Order.Verify that i18n of the default label still works.
/wp-admin/options-general.phpand selectGermanas theSite Language./wp-admin/update-core.php?force-check=1and fetch translations.PayPal, e.g.Credit Card (Stripe).Kostenpflichtig bestellen.WooCommerce Visibility
Changelog