This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix failing filter test #7253
Merged
Fix failing filter test #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The release ZIP for this PR is accessible via: |
|
Size Change: 0 B Total Size: 916 kB ℹ️ View Unchanged
|
wavvves
approved these changes
Sep 29, 2022
nielslange
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thanks for working on this, @alexflorisca! The fix works as expected, and I'll merge it now. The two e2e tests, that are still failing, should be fixed with #7206.
|
You could also invalidate the cache by passing in different dependencies. |
alexflorisca
added
the
skip-changelog
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a failing unit test on trunk introduced in #7154
The test failes because
cachedValueswas changed from a ref (that was updated every render), to a global (which is not). Because in that test file, we run the__experimentalApplyCheckoutFiltermultiple times, in different tests, the function actually returns the cached value after the second time it runs, instead of the new value we want (in the case of the failing test, we want to throw an error).This PR uses a new filter name for the failing test to bypass the caching mechanism.