This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove workarounds for site-editing-templates tests #7151 #7568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: refactor
rubikuserbot
requested review from
a team and
danielwrobert
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
remove workaround for site-editing-templates tests
gigitux
force-pushed
the
fix/remove-comments-6-1-wp
branch
from
55d6cdd
to
51a3f58
Compare
|
Size Change: 0 B Total Size: 974 kB ℹ️ View Unchanged
|
TypeScript Errors ReportFiles with errors: 430 🎉 🎉 This PR does not introduce new TS errors. |
TypeScript Errors ReportFiles with errors: 448 🎉 🎉 This PR does not introduce new TS errors. |
TypeScript Errors ReportFiles with errors: 448 🎉 🎉 This PR does not introduce new TS errors. |
TypeScript Errors ReportFiles with errors: 448 🎉 🎉 This PR does not introduce new TS errors. |
…ocks into fix/remove-comments-6-1-wp
gigitux
force-pushed
the
fix/remove-comments-6-1-wp
branch
from
72ea9ef
to
3d03dab
Compare
…mmerce/woocommerce-blocks into fix/remove-comments-6-1-wp
gigitux
force-pushed
the
fix/remove-comments-6-1-wp
branch
from
3d03dab
to
c288e7e
Compare
There was a problem hiding this comment.
@gigitux code looks good and the checks seem to all be passing on the PR.
When I run the tests locally, however, they aren't failing but they seem stuck in a pending state:
I ran the following commands on my machine:
npm run wp-env destroy
npm run wp-env start
npm run test:e2e -- site-editing-templates
Let me know if I'm missing anything or if that's expected. Other than that, LGTM!
FYI:
|
danielwrobert
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Based on @dinhtungdu's explanation (thanks Tung 🙌 ) I think everything is working as expected here!
LGTM! 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some workarounds that were introduced to avoid test failing. More context here #7151
Fixes #7151
Testing
User Facing Testing
WooCommerce Visibility