This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Respect core settings for showing the Checkout block #7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: bug
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 431 🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: -686 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
|
The release ZIP for this PR is accessible via: |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
woocommercebot
requested review from
a team and
mikejolley
and removed request for
a team
alexflorisca
approved these changes
Dec 16, 2022
mikejolley
approved these changes
Dec 16, 2022
Co-authored-by: Mike Jolley <mike.jolley@me.com>
nielslange
force-pushed
the
fix/7823-respect-core-settings-for-showing-checkout
branch
from
0fc0177
to
664b639
Compare
mikejolley
approved these changes
Dec 19, 2022
nielslange
deleted the
fix/7823-respect-core-settings-for-showing-checkout
branch
ralucaStan
added
the
focus: settings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7823
In #7823, @senadir reported that the following two WooCommerce core settings are not respected by the Checkout block:
This PR aims to ensure that these WooCommerce core settings are respected by the Checkout block and that the Checkout block behaves identical to the shortcode-based checkout.
Testing
Show login prompt when guest checkout and account creation (in core) are disabled
/wp-admin/admin.php?page=wc-settings&tab=account.Guest checkout→Allow customers to place orders without an account.Account creation→Allow customers to create an account during checkout.You must be logged in to checkout. Click here to log in..Show checkout when guest checkout is enabled, but account creation is disabled
/wp-admin/admin.php?page=wc-settings&tab=account.Guest checkout→Allow customers to place orders without an account.Account creation→Allow customers to create an account during checkout.Guestas aCustomer:Show checkout when guest checkout is disabled, but account creation is enabled
/wp-admin/admin.php?page=wc-settings&tab=account.Guest checkout→Allow customers to place orders without an account.Account creation→Allow customers to create an account during checkout.Customer:Show checkout when guest checkout and account creation are enabled, but don't create account
/wp-admin/admin.php?page=wc-settings&tab=account.Guest checkout→Allow customers to place orders without an account.Account creation→Allow customers to create an account during checkout.Create an account?is not checked.Guestas aCustomer.Show checkout when guest checkout and account creation are enabled, and create account
/wp-admin/admin.php?page=wc-settings&tab=account.Guest checkout→Allow customers to place orders without an account.Account creation→Allow customers to create an account during checkout.Create an account?is checked.Customer:Verify that display logic is in sync
WooCommerce Visibility
Changelog