Address invalid nonce due to no customer session in a more robust way #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures a customer session has been created (for a consistent nonce) before scripts are enqueued, at which point headers may have already been sent. Partially reverts e5c5c47, which fixed the bug on some sites but not others.
dechov
deleted the
fix/single-product-spb-failing-without-existing-session
branch
This was referenced Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures a customer session has been created early enough (for a consistent AJAX nonce) – before scripts are enqueued, at which point headers may have already been sent.
Partially reverts e5c5c47, which fixed the bug on some sites by initializing the session, but on other sites, the header template was being printed before the session could be saved, which was too late for saving the cookie, and so there was a new session (and therefore new nonce) when the AJAX request was processed.
(copied from #445:)
Testing the failure case on sites that still have this issue, such as https://jurassic.ninja/ sites:
Again...