Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the payment method terms on the checkout pages #2888

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

a-danae
Copy link
Contributor

@a-danae a-danae commented Feb 10, 2024

Changes proposed in this Pull Request:

  • Pass the terms property for reusable payment method types
  • Update the terms property according to whether the user is saving a payment method

Testing instructions

  1. Change the store currency to EUR
  2. Enable UPE, under the Stripe's settings tab
  3. Enable Cards, Bancontact, SEPA, iDEAL, and Sofort
  4. As a shopper, go to the classic checkout page
  5. For each of these payment methods, confirm that:
  • When "Save payment information to my account for future purchases" is checked off, the terms must be displayed
  • When this input isn't checked, no terms must be displayed

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Added changelog entry in both changelog.txt and readme.txt (or does not apply)
  • Tested on mobile (or does not apply)

Post merge

Base automatically changed from add/deferred-intent to develop February 28, 2024 16:53
@github-actions github-actions bot added the Stale label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant