Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the value entering of the billing state field in e2e test compatible with WC < 9.2 #457

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

While performing the release in #456, the e2e test keep failing. Ref: #454

This PR make it compatible with WC < 9.2.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Detailed test instructions:

  1. npm run wp-env:up
  2. npm run -- wp-env run tests-cli -- wp plugin update woocommerce --version=9.1.4 && npm run -- wp-env run tests-cli -- wp wc update
  3. npm run test:e2e
  4. Confirm tests pass
  5. npm run -- wp-env run tests-cli -- wp plugin update woocommerce --version=9.2.0-rc.1 && npm run -- wp-env run tests-cli -- wp wc update
  6. npm run test:e2e
  7. Confirm tests pass

Changelog entry

@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Aug 14, 2024
@eason9487 eason9487 self-assigned this Aug 14, 2024
@eason9487
Copy link
Member Author

Ran e2e test with WooCommerce 9.1.4 and 9.2.0-rc.1 via GitHub actions:

I will be merging this PR without code reviews.

@eason9487 eason9487 merged commit 146b651 into trunk Aug 14, 2024
5 checks passed
@eason9487 eason9487 deleted the dev/compat-e2e-billing-state-input branch August 14, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant