Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed date to fix flaky unit test of StoreStatsChartViewModel #12594

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

itsmeichigo
Copy link
Contributor

Description

As the title suggests, this PR aims to fix flaky tests for StoreStatsChartViewModel due to the use of Date(). The fix is to use a fixed date to avoid failed tests.

Testing instructions

CI passing is sufficient

Screenshots

N/A


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added the category: unit tests Related to unit testing. label Apr 29, 2024
@itsmeichigo itsmeichigo added this to the 18.5 milestone Apr 29, 2024
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12594-fc36797
Version18.4
Bundle IDcom.automattic.alpha.woocommerce
Commitfc36797
App Center BuildWooCommerce - Prototype Builds #8876
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@selanthiraiyan selanthiraiyan self-assigned this Apr 29, 2024
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. ❤️

@itsmeichigo itsmeichigo merged commit e62c726 into trunk Apr 29, 2024
25 of 28 checks passed
@itsmeichigo itsmeichigo deleted the fix/stat-chart-flaky-unit-test branch April 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: unit tests Related to unit testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants