Dynamic Dashboard: Clean up legacy dashboard flow #12602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… task/12601-remove-legacy-store-stats
Generated by 🚫 Danger |
|
|
Base automatically changed from
task/12596-remove-legacy-onboarding-feature-flags
to
trunk
April 29, 2024 14:27
selanthiraiyan
approved these changes
Apr 30, 2024
| case .weekly: | ||
| dateFormatter = DateFormatter.Charts.chartAxisDayFormatter | ||
| case .monthly: | ||
| dateFormatter = DateFormatter.Charts.chartAxisMonthFormatter |
There was a problem hiding this comment.
nit: chartAxisMonthFormatter and chartAxisHourFormatter are not used anywhere else. Should we consider deleting those from WooCommerce/Classes/Extensions/DateFormatter+Helpers.swift?
There was a problem hiding this comment.
Nice catch! Removed in 26a5371.
| /// Uploads the answers from the store creation profiler flow | ||
| /// | ||
| func uploadProfilerAnswers() async { | ||
| await storeCreationProfilerUploadAnswersUseCase.uploadAnswers() |
There was a problem hiding this comment.
storeCreationProfilerUploadAnswersUseCase property can be deleted as well.
There was a problem hiding this comment.
Removed in d125d80.
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12601
Description
Since we migrated the dashboard screen to the SwiftUI views, we need to clean up the legacy UIKit code. This PR removes all the outdated code so it's quite large. Most of the changes are deletion of unused files. There are also some small changes in
DashboardViewModelandStoreStatsPeriodViewModelto remove unused methods.Testing instructions
Smoke test the dynamic dashboard features following #12563 to confirm that everything still works correctly.
Screenshots
N/A
RELEASE-NOTES.txtif necessary.