Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change badge view in order products list text color #12630

Merged
merged 6 commits into from
May 3, 2024

Conversation

bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented May 2, 2024

Closes #12628

Description

Noticed that in dark mode badge view text color is to dark. Since the background color of badg view is black I set the text color to plain white.

Testing instructions

  • Open orders
  • Add product(s) to the order
  • Check that the number if badge is readable
  • Test it in both light and dark mode

Screenshots

Before After
Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2024-05-02 at 11 22 22 Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2024-05-02 at 11 20 50

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@bozidarsevo bozidarsevo added the type: enhancement A request for an enhancement. label May 2, 2024
@bozidarsevo bozidarsevo added this to the 18.5 milestone May 2, 2024
@bozidarsevo bozidarsevo changed the title Change badge view text color Change badge view in order products list text color May 2, 2024
@bozidarsevo bozidarsevo marked this pull request as ready for review May 2, 2024 09:28
@bozidarsevo bozidarsevo requested a review from jaclync May 2, 2024 09:29
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 2, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12630-2ad71e1
Version18.5
Bundle IDcom.automattic.alpha.woocommerce
Commit2ad71e1
App Center BuildWooCommerce - Prototype Builds #8948
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Maybe it's worth noting this in the release notes?

@iamgabrielma iamgabrielma modified the milestones: 18.5, 18.6 May 3, 2024
@bozidarsevo bozidarsevo enabled auto-merge May 3, 2024 06:53
@@ -1,5 +1,9 @@
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]

18.6
-----
- [*] Change text color in badge view in order products list. [https://github.com/woocommerce/woocommerce-ios/pull/12630]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: maybe we can mention "dark mode" as a "fix" since this change doesn't affect the light mode

@bozidarsevo bozidarsevo merged commit 7793282 into trunk May 3, 2024
21 of 22 checks passed
@bozidarsevo bozidarsevo deleted the bozidarsevo/fix-badge-view-text-color branch May 3, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order form: quantity badge text in the product card is not very readable in dark mode
4 participants