-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change badge view in order products list text color #12630
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Maybe it's worth noting this in the release notes?
RELEASE-NOTES.txt
Outdated
@@ -1,5 +1,9 @@ | |||
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>] | |||
|
|||
18.6 | |||
----- | |||
- [*] Change text color in badge view in order products list. [https://github.com/woocommerce/woocommerce-ios/pull/12630] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: maybe we can mention "dark mode" as a "fix" since this change doesn't affect the light mode
Closes #12628
Description
Noticed that in dark mode badge view text color is to dark. Since the background color of badg view is black I set the text color to plain white.
Testing instructions
Screenshots
RELEASE-NOTES.txt
if necessary.