Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Release/5.2 back into develop #3002

Merged
merged 7 commits into from Oct 19, 2020
Merged

Merge Release/5.2 back into develop #3002

merged 7 commits into from Oct 19, 2020

Conversation

loremattei
Copy link
Contributor

Merge Release/5.2 back into develop

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@loremattei loremattei added the category: releases For PRs that merge a `release/*` branch into `develop` or `trunk`. label Oct 16, 2020

De plus, nos produits essentiels intègrent des champs supplémentaires qui peuvent être modifiés : étiquettes, catégories, type de produit, activer/désactiver les avis et visibilité.

Nous proposons également une mise à jour pour Apple Sign In. Si vous déconnectez l’identifiant Apple de l’application WordPress (Réglages > Identifiant Apple > Mot de passe et sécurité > Applications utilisant l’identifiant Apple), l’application se déconnectera au lancement ou si vous basculez entre les applications. Ainsi vous ne restez pas connecté si vous ne le souhaitez pas !
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit on the l10n (not sure where to report it tho):

this reads more to me like "There is also an Apple Sign In update available" as if it was a product the user could purchase or update themselves. I feel a better wording would be "Nous avons également des nouvelles à propos d'Apple Sign In." (which would be more close to a literal translation of ~ "Some news on the Apple Sign In front")

@AliSoftware AliSoftware self-requested a review October 16, 2020 16:08
@peril-woocommerce
Copy link

Messages
📖 This PR has the 'Releases' label: some checks will be skipped.

Generated by 🚫 dangerJS

@loremattei loremattei merged commit 803d6b8 into develop Oct 19, 2020
@loremattei loremattei deleted the release/5.2 branch October 19, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: releases For PRs that merge a `release/*` branch into `develop` or `trunk`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants