Networking: Notifications Mark II #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions-networking-mk2
jleandroperez
added
the
feature: notifications
Generated by 🚫 Danger |
bummytime
approved these changes
Oct 25, 2018
There was a problem hiding this comment.
@jleandroperez This is all great. I have some general comments, but I really couldn't find any issues in this PR.
|
|
||
| /// Returns a String with the JSON Representation of the receiver. | ||
| /// | ||
| func toJSONEncoded() -> String? { |
|
|
||
| /// WordPress.com Request Error | ||
| /// | ||
| public struct DotcomError: Error, Decodable { |
There was a problem hiding this comment.
We prolly should have done this a while ago...
| let encoded = try! encoder.encode(parameters) | ||
|
|
||
| return String(data: encoded, encoding: .utf8) | ||
| return parameters.toJSONEncoded() |
|
|
||
| /// WordPress.com Response Validator | ||
| /// | ||
| struct DotcomValidator { |
There was a problem hiding this comment.
I love this approach with DotcomValidator — preprocessing the response through this first via Remote will give us the latitude to handle many different error conditions (and it's more efficient than letting a mapper error out).
mindgraffiti
approved these changes
Oct 26, 2018
| /// | ||
| public func updateReadStatus(_ notificationID: String, read: Bool, completion: @escaping (Error?) -> Void) { | ||
| // Note: Isn't the API wonderful? | ||
| let booleanFromPlanetMars = read ? Constants.readAsInteger : Constants.unreadAsInteger |
|
I'll document @bummytime @mindgraffiti thanks A LOT for the review!!!! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Testing:
Ref. #19
cc @bummytime @mindgraffiti
Thanks in advance!!