Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storage to include Notifications #390

Merged
merged 3 commits into from
Oct 29, 2018
Merged

Update Storage to include Notifications #390

merged 3 commits into from
Oct 29, 2018

Conversation

bummytime
Copy link
Member

@bummytime bummytime commented Oct 29, 2018 •
edited

screen shot 2018-10-29 at 10 47 06 am

This small PR:

  • Updates the v5 datamodel (not released to beta users yet) to include Notifications
  • Includes the Note+CoreDataClass and Note+CoreDataProperties NSMO class/extension
  • Adds the appropriate typealiases to Yosemite's Model

Not a whole bunch here, but submitting this so the subsequent PR's smaller. :-)

Ref: #19

Testing

  • Make sure the data model updates make sense
  • Build and run the app; verify the unit tests are ✅

@jleandroperez could you take a quick peek?

@bummytime
Added Notifications to v5 data model
0fbef2b
@bummytime
Merge branch 'develop' of github.com:woocommerce/woocommerce-ios into…
31a8d02 
… issue/19-notifications-storage

* 'develop' of github.com:woocommerce/woocommerce-ios:
  Localize: Switching to UTF8
  Updates Localizable.strings file
  Adding Strings Extraction script
@bummytime bummytime added the feature: notifications Related to notifications or notifs. label Oct 29, 2018
@bummytime bummytime added this to the 0.10 milestone Oct 29, 2018
@bummytime bummytime self-assigned this Oct 29, 2018
@bummytime bummytime added this to MVLP Backlog in MVLP Kanban Board via automation Oct 29, 2018
@bummytime bummytime moved this from MVLP Backlog to Review/Testing in MVLP Kanban Board Oct 29, 2018
@astralbodies astralbodies mentioned this pull request Oct 29, 2018
Closed
39 tasks
@wpmobilebot
Copy link
Collaborator

1 Warning
⚠️ Core Data: Do not edit an existing model in a release branch unless it hasn’t been released to testers yet. Instead create a new model version and merge back to develop soon.

Generated by 🚫 Danger

jleandroperez
jleandroperez approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this Matt!!!

:shipit:

@bummytime bummytime merged commit b16d901 into develop Oct 29, 2018
MVLP Kanban Board automation moved this from Review/Testing to Done/Merged Oct 29, 2018
@bummytime bummytime deleted the issue/19-notifications-storage branch October 29, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleandroperez jleandroperez jleandroperez approved these changes

Assignees

@bummytime bummytime

Labels
feature: notifications Related to notifications or notifs.
Projects
No open projects
MVLP Kanban Board
  
0.10
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bummytime @wpmobilebot @jleandroperez