StringDescriptor Formatter #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
jleandroperez
changed the title
jleandroperez
added
feature: notifications
mindgraffiti
reviewed
Nov 2, 2018
| /// Returns the receiver *Bold* version. | ||
| /// | ||
| var bold: UIFont { | ||
| guard let italicDescriptor = fontDescriptor.withSymbolicTraits(.traitBold) else { |
There was a problem hiding this comment.
I think you mean boldDescriptor instead of italicDescriptor here
| return self | ||
| } | ||
|
|
||
| return UIFont(descriptor: italicDescriptor, size: pointSize) |
| .replacingOccurrences(of: " \t", with: String.space + String.hairSpace) // tabs after a space | ||
| .replacingOccurrences(of: "\t@", with: String.hairSpace + "@") // tabs before @mentions | ||
| .replacingOccurrences(of: "\t.", with: String.hairSpace + ".") // tabs before a space | ||
| .replacingOccurrences(of: "\t,", with: String.hairSpace + ",") // tabs cefore a comman |
There was a problem hiding this comment.
nitpicky: comment tabs before a comma
| }() | ||
|
|
||
|
|
||
| /// Styles: Notification Defailts / Badge Blocks |
There was a problem hiding this comment.
nitpicky - Defaults instead of Defailts
bummytime
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
@jleandroperez I poured over the code and did not find any issues (beyond what @mindgraffiti noted) — StringFormatter looks straight-forward in terms of usage. Can't wait to give this a try in the UI!
!
| @@ -4,8 +4,16 @@ import UIKit | |||
| // MARK: - Style defines the basic API of a Woo Skin. | |||
| // | |||
| protocol Style { | |||
There was a problem hiding this comment.
Thanks for organizing this! ❤️
|
Thank you both!! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR implements a new tool, to be used in the Notifications List / Details, to be known as StringFormatter.
Given a String, a collection of Range Descriptors, and Styles (Bold, Italics, etc), this tool will produce a NSAttributedString instance with its metadata stylized.
Testing:
Notes:
StringStyles.swift contains a (temporary) private structure, called
NukeMe. This will be removed, as soon as we do have a way to visually test how this class works, and get to fine-tune the colors.(Subtask added in the main ticket).
cc @bummytime thanks in advance!!