Notifications: Added NotificationStore and friends #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue/19-notifications-yosemite * 'develop' of github.com:woocommerce/woocommerce-ios: (37 commits) Better named variables AddANoteViewController: Wiring SwitchTableViewCell PrivacySettingsViewController: Wiring SwitchTableViewCell SwitchTableViewCell: Standard Subtitle UITableViewCell + Switch Write a unit test for a user opt-out scenario Missed a typo Clear tracks user data when a user opts out Fix broken pragma mark Give Privacy Settings table and Order Details table some empty space where footer would go Make changes for Crashlytics - turn off crash reporting if Collect info setting is turned off. Change method names from `optedOut` to `optedIn` Move URL constants to WooConstants Objective-C leaking into my brain. Removed parens around `if bool` Missed user defaults changes - default to user has not opted in to tracking Default to user has not opted in to analytics tracking. Remove optional for analytics provider (because it prevents unit testing) Add unit test for clearAllEvents() Touch up Tracks reporting for Settings Add logging Set up the interface to use the opt-out feature ...
bummytime
added
feature: notifications
… issue/19-notifications-yosemite * 'develop' of github.com:woocommerce/woocommerce-ios: Add env.example Add PRs list tool Updates Project NotificationsViewController: Wiring tabBar Initialization MainTabBarController: Removes unneeded setup Moving Notifications to its own Storyboard Implements Array+Notes
bummytime
removed
the
status: do not merge
Generated by 🚫 Danger |
jleandroperez
approved these changes
Nov 2, 2018
| head = 0 | ||
| } | ||
|
|
||
| return element |
There was a problem hiding this comment.
Q: unless i'm missing something HUGE (which i probably am), wouldn't something like this work as well?
func dequeue() -> T? {
return array.removeFirst()
}
There was a problem hiding this comment.
@jleandroperez Yeah it definitely would. This code is an optimized version of the Queue data struct which has better performance.
|
Thanks for the review @jleandroperez !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
NotificationStoreandNotificationActionStorageManagerType(needed when saving/updating notifications in storage)MockupNetworksuch that a FIFO response queue can used — useful for testing the same endpoint where multiple responses are needed sequentially (e.g. notifications)Re: #19
Testing
@jleandroperez finally ready for a review now!