Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications List Mark I #402

Merged
merged 29 commits into from
Nov 6, 2018
Merged

Notifications List Mark I #402

merged 29 commits into from
Nov 6, 2018

Conversation

jleandroperez
Copy link
Collaborator

@jleandroperez jleandroperez commented Nov 5, 2018 •
edited

Description:

This PR is a "Work in Progress":

  • Store-Y Notifications are (yet) not being filtered
  • The UI is not matching 100% the mockups. We'll address that in upcoming PR's!
  • Loading / Empty states not wired

Ref. #19

Details:

  • NotificationsViewController now displays stored Notifications
  • New Font: noticon
  • New Date Formatter: iso8601
  • New Notification Unit Test (timestamp as date parsing was failing!)
  • New NSAttributedString trimming method
  • Age Enum promoted to its own file

Testing:

  1. Log into a Dotcom Account
  2. Press over the Notifications tab
  3. Verify the Notifications list matches with what WPiOS renders

cc @bummytime @mindgraffiti
Thanks in advance!!

@jleandroperez
Adding Noticons Font
d185e65
@jleandroperez
UIFont+Helpers: New Noticons Helper
2470160
@jleandroperez
AuthenticatedState: Wiring NotificationStore
af04f2e
@jleandroperez
Relocating NotificationsViewController
2905915
@jleandroperez
Notifications.storyboard: Wiring Datasource
3029218
@jleandroperez
Note: Woo Methods
74e5da8
@jleandroperez
Implements NoteTableViewCell
8399d4e
@jleandroperez
NoteTableViewCell: Noticon is now a string
2cd27cc
@jleandroperez
StringFormatter+Notes: Trimming by default
407e84e
@jleandroperez
NSAttributedString+Helpers: Trimming Methods
974d58b
@jleandroperez
Updates Project
0293915
@jleandroperez
NotificationsViewController: Subject + Storage Caching
1300702
@jleandroperez
New Age Entity
d60deb0
@jleandroperez
Order+Woo: Nukes (Hidden) Age Entity
540eefe
@jleandroperez
StorageOrder+Woo: Wiring Age Entity
38d4cff
@jleandroperez
Notifications.storyboard: Adjusting TableView Style
80109fb
@jleandroperez
NoteTableViewCell: Adjusting noticon font
f635430
@jleandroperez
StringStyles: Tunning subject + snippet styles
03ae043
@jleandroperez
Nukes Order+Woo
f58b740
@jleandroperez
Age: Cleanup
bb8ba12
@jleandroperez
StorageOrder+Woo: Cleanup
63c5953
@jleandroperez
NotificationsViewController: Wiring Age Grouping
99425ba
@jleandroperez jleandroperez added this to the 0.11 milestone Nov 5, 2018
@jleandroperez jleandroperez self-assigned this Nov 5, 2018
@wpmobilebot
Copy link
Collaborator

1 Warning
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

@jleandroperez jleandroperez requested review from mindgraffiti and bummytime and removed request for mindgraffiti November 5, 2018 19:53
@jleandroperez jleandroperez added feature: notifications Related to notifications or notifs. and removed [Status] Not Ready for Review labels Nov 5, 2018
@jleandroperez jleandroperez changed the title [WIP] Notifications List Mark I Notifications List Mark I Nov 5, 2018
@astralbodies astralbodies mentioned this pull request Nov 5, 2018
Closed
39 tasks
mindgraffiti
mindgraffiti approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ UI sanity check
✅ code review

one quick question (unrelated to this PR)

:shipit:

Networking/Networking/Extensions/DateFormatter+Woo.swift Show resolved Hide resolved
@bummytime bummytime added this to MVLP Backlog in MVLP Kanban Board via automation Nov 6, 2018
@bummytime bummytime moved this from MVLP Backlog to Review/Testing in MVLP Kanban Board Nov 6, 2018
bummytime
bummytime approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleandroperez I ❤️ all of this! SO great to finally see notes appearing in the app!

:shipit:

@jleandroperez
Copy link
Collaborator Author

Thank you both!!! 🔥

@jleandroperez jleandroperez merged commit 8263860 into develop Nov 6, 2018
MVLP Kanban Board automation moved this from Review/Testing to Done/Merged Nov 6, 2018
@jleandroperez jleandroperez deleted the issue/19-notifications-list branch November 6, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bummytime bummytime bummytime approved these changes

@mindgraffiti mindgraffiti mindgraffiti approved these changes

Assignees

@jleandroperez jleandroperez

Labels
feature: notifications Related to notifications or notifs.
Projects
No open projects
MVLP Kanban Board
  
0.11
Milestone
0.11 ❄️
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jleandroperez @wpmobilebot @bummytime @mindgraffiti