Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Adds comment moderation support in Networking #415

Merged
merged 7 commits into from
Nov 8, 2018

Conversation

bummytime
Copy link
Member

This PR adds the ability to moderate comments (trash/untrash, spam/unspam, approve/unapprove) in a new CommentRemote class. I did not create a Networking model to encapsulate the response from the endpoint. Instead, I simply parse the response and return the updated CommentStatus via CommentResultMapper.

Ref: #19

Testing

  1. Review the logic here
  2. Run the unit tests — verify they are ✅

@bummytime bummytime added the feature: notifications Related to notifications or notifs. label Nov 8, 2018
@bummytime bummytime added this to the 0.11 milestone Nov 8, 2018
@bummytime bummytime self-assigned this Nov 8, 2018
@bummytime bummytime added this to MVLP Backlog in MVLP Kanban Board via automation Nov 8, 2018
@bummytime bummytime moved this from MVLP Backlog to Review/Testing in MVLP Kanban Board Nov 8, 2018
@astralbodies astralbodies mentioned this pull request Nov 8, 2018
39 tasks
@wpmobilebot
Copy link
Collaborator

1 Warning
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

Copy link
Collaborator

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEAT!!!! End to end, shiny
Thank you so much!!!!

:shipit:

@bummytime bummytime merged commit 03a8cae into develop Nov 8, 2018
MVLP Kanban Board automation moved this from Review/Testing to Done/Merged Nov 8, 2018
@bummytime bummytime deleted the issue/19-networking-comment-spam branch November 8, 2018 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: notifications Related to notifications or notifs.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants