-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications: Empty + Loading State Support #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jleandroperez:
✅ Verify that the (forced) Sync'ing State looks good!
✅ Verify the Sync'ing State looks good
✅ Verify the Results are rendered once sync'ing concludes
✅ Verify the Ghosts are not rendered during Sync
Code looks grand. I vote !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ empty state
✅ sync state
✅ device test
❓add FSM meaning to pragma, then !
} | ||
|
||
|
||
// MARK: - FSM Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's FSM mean? I'd use // MARK: - Fruitcake Seeking Moo (FSM) Management
for the full title here
Thank you both!! |
Details:
This PR implements a FSM in the Notifications List UI, in charge of rendering Empty State // Sync'ing State // Populated State.
cc @bummytime @mindgraffiti
Thanks in advance!!
Ref. #19
Scenario: Empty State
Verify that the (forced) Empty State renders an Overlay Placeholder, similar to the one we've got in the Orders tab.
Scenario: Sync'ing State
Verify that the (forced) Sync'ing State looks good!
Scenario: Regular Usage