Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: Empty + Loading State Support #425

Merged
merged 12 commits into from
Nov 13, 2018

Conversation

jleandroperez
Copy link
Collaborator

@jleandroperez jleandroperez commented Nov 12, 2018

Details:

This PR implements a FSM in the Notifications List UI, in charge of rendering Empty State // Sync'ing State // Populated State.

cc @bummytime @mindgraffiti
Thanks in advance!!

Ref. #19

Scenario: Empty State

  1. Check out commit c5b699b
  2. Launch the app

Verify that the (forced) Empty State renders an Overlay Placeholder, similar to the one we've got in the Orders tab.

Scenario: Sync'ing State

  1. Check out commit cc158f4
  2. Launch the app

Verify that the (forced) Sync'ing State looks good!

Scenario: Regular Usage

  1. Check out the latest commit!
  2. Fresh install the app
  3. Log into WC
  4. Press the Notifications Tab
  5. Verify the Sync'ing State looks good
  6. Verify the Results are rendered once sync'ing concludes
  7. Pull to Refresh
  8. Verify the Ghosts are not rendered during Sync

@jleandroperez jleandroperez added the feature: notifications Related to notifications or notifs. label Nov 12, 2018
@jleandroperez jleandroperez added this to the 0.11 milestone Nov 12, 2018
@jleandroperez jleandroperez self-assigned this Nov 12, 2018
@astralbodies astralbodies mentioned this pull request Nov 12, 2018
39 tasks
@bummytime bummytime added this to MVLP Backlog in MVLP Kanban Board via automation Nov 13, 2018
@bummytime bummytime moved this from MVLP Backlog to Review/Testing in MVLP Kanban Board Nov 13, 2018
Copy link
Member

@bummytime bummytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jleandroperez:

✅ Verify that the (forced) Sync'ing State looks good!
✅ Verify the Sync'ing State looks good
✅ Verify the Results are rendered once sync'ing concludes
✅ Verify the Ghosts are not rendered during Sync

Code looks grand. I vote :shipit: !

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ empty state
✅ sync state
✅ device test

❓add FSM meaning to pragma, then :shipit: !

}


// MARK: - FSM Management
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's FSM mean? I'd use // MARK: - Fruitcake Seeking Moo (FSM) Management for the full title here

@jleandroperez
Copy link
Collaborator Author

Thank you both!!

@jleandroperez jleandroperez merged commit d70fbfa into develop Nov 13, 2018
MVLP Kanban Board automation moved this from Review/Testing to Done/Merged Nov 13, 2018
@jleandroperez jleandroperez deleted the issue/19-notifications-fsm branch November 13, 2018 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: notifications Related to notifications or notifs.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants