Notifications: New Order Details #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f3b54fb.
jleandroperez
added
the
feature: notifications
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
mindgraffiti
approved these changes
Nov 15, 2018
bummytime
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
So I looked hard for something to complain about here — just couldn't find anything. :-)
I smoke tested this pretty well:
✅ All of the order details-specific functionality worked as expected (add a note, complete order, etc)
✅ Overall screen looks great on a variety of devices (portrait and land)
✅ Code is square
✅ Unit tests are good
| // MARK: - OrderLoaderViewController: Loads asynchronously an Order (given it's OrderID + SiteID). | ||
| // On Success the OrderDetailsViewController will be rendered "in place". | ||
| // | ||
| class OrderLoaderViewController: UIViewController { |
There was a problem hiding this comment.
I like the entire concept of this VC subclass — very simple and straight-forward way to spin up the order details VC. A+
There was a problem hiding this comment.
Patching OrderDetailsViewController would have been a nightmare! Thank you Matt!!
|
Thank you both!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
In this PR we're implementing a new "Loader", to be called OrderLoaderViewController.
This tool allows us to display a spinner, in place, async load an Order (given its orderID + siteID), and render the OrderDetails, right there, in place.
cc @bummytime @mindgraffiti
Thanks in advance!!
Testing: Successful Flow
Verify that a ViewController shows up immediately. A spinner should kick off, and the Order Details should appear shortly.
Testing: Failure Flow
Verity that a spinner shows up immediately. Shortly after, the "Failure Overlay" should appear onscreen, with a retry button.