Notifications: Adds the green dot badge to the notification tab #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue/19-green-dot * 'develop' of github.com:woocommerce/woocommerce-ios: Quick fix for notifications navbar button Tweaked NoteTableViewCell.xib for dynamic type OrderLoaderViewController: Updating reloadOrder Hook Revert "Revert to this commit to test OrderLoader Failure State" Revert to this commit to test OrderLoader Failure State Implementing OrderLoaderViewController NotificationsViewController: Wiring OrderLoaderVIewController OrderDetailsViewController: Adding comment Updating Project Orders.storyboard: Updating ViewController Identifier MetaContainer: New Key UIStoryboard: Woo Methods Use 'cocoapods-repo-update' CocoaPods plugin
jleandroperez
approved these changes
Nov 16, 2018
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to show/hide a "green dot badge" on any tab in
MainTabBarControllervia theshowDotOn(_ tab: WooTab)andhideDotOn(_ tab: WooTab)funcs. I also added a simpleUIViewfade in/out animation helper in a newUIView+Animation.swiftextension.This badge is temporarily wired up in
NotificationsViewControllerlooking for unread notes when theresultsControllerupdates. This logic should be removed whenPushNotificationManageris added.Ref: #19
Testing
Feel free to test multiple devices and in both landscape & portrait orientations.
@jleandroperez could you take a peek at this?