Notifications: mark individual note as read #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
approved these changes
Nov 20, 2018
| @@ -51,7 +51,7 @@ struct StringFormatter { | |||
|
|
|||
| // MARK: - Private | |||
| // | |||
| private extension StringFormatter { | |||
| private extension StringFormatter { | |||
… issue/19-mark-as-read * 'develop' of github.com:woocommerce/woocommerce-ios: NoteDetailsCommentTableViewCell: Fixes clipping NotificationsViewController: Temporary Fix Addressing Linter Warnings Don't run 'pod repo update' from 'rake dependencies' Bump cocoapods-repo-update to 0.0.3 Update usage description in Info.plist Added last seen logic to NotificationsVC Update translations Updating version to Mark 0.11 NotificationDetailsViewController: Adding Comments NoteDetailsCommentTableViewCell: Wiring Action Buttons Updates Project Implements UIButton+Animations Implements VerticalButton # Conflicts: # WooCommerce/Classes/ViewRelated/Notifications/NotificationsViewController.swift
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another quick PR which adds the mark-as-read logic to
NotificationsViewController. A note will be updated as read when a user taps on a specific notification in the list screen (and the note is not already "read").Ref: #19
Testing
Scenario 1: Send mark-as-read update when tapping on unread notif
NotificationsViewControllerScenario 2: Don't send update if notification is already read
NotificationsViewController@jleandroperez could you take a quick peek at this?