Shipping Labels: Validate that address name field is not empty #4644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds local validation to check that the shipping address name field is not empty when creating shipping labels. If it is empty, it opens the Edit Address screen to prompt the user to enter a name.
This was fixed on
develop
and the fix is being introduced torelease/7.1
based on beta testing feedback. (Internal ref: p5T066-2uU-p2#comment-9242)FYI @jkmassel since this is targeting the 7.1 release.
Changes
address.name.isEmpty
before doing the remote address validation inShippingLabelFormViewModel
.Testing
First name
andLast name
are empty in your WordPress.com account settings.Ship from
section, tap the "Continue" button.Submitter Checklist
Update release notes:
RELEASE-NOTES.txt
if necessary.