Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create editor skeleton on add/edit product pages #36991

Closed
3 tasks done
joshuatf opened this issue Feb 28, 2023 · 2 comments · Fixed by #37023
Closed
3 tasks done

Create editor skeleton on add/edit product pages #36991

joshuatf opened this issue Feb 28, 2023 · 2 comments · Fixed by #37023
Assignees
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.

Comments

@joshuatf
Copy link
Contributor

joshuatf commented Feb 28, 2023

There is some prior art for the initial editor skeleton and framework in this POC PR.

This issue will involve adding the base editor components for use with a couple of placeholder blocks.

Note that we can probably combine the add/edit product pages into a single page/component this time instead of creating 2 separate addProductPage and editProductPage components.

Updating the routes of the current editor will be done as part of this issue: #36989

Acceptance criteria

  • The skeleton editor shows some placeholder blocks until the other blocks are ready to be added
  • Visiting the add product page should show the new skeleton editor
  • Visiting the edit product page should show the new skeleton editor
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Feb 28, 2023
@joshuatf
Copy link
Contributor Author

Estimate: 2

A lot can be pulled from the POC PR linked above, but I'm estimating a 2 to account for time to understand how this gets hooked up and works. Also we may have some React type conflicts again with pnpm that could elongate this issue.

@jonathansadowski jonathansadowski added plugin: woocommerce Issues related to the WooCommerce Core plugin. status: prioritization and removed status: awaiting triage This is a newly created issue waiting for triage. labels Feb 28, 2023
@louwie17
Copy link
Contributor

louwie17 commented Mar 1, 2023

Changing it to a 3 to be cautious.

I do propose that we should replace the current product editor routes and pointing to this Component, but as part of this issue to create an additional route for the old editor (just for now, so we could still test things between the old and new editor as I could see that being beneficial).
I noticed there is actually a separate issue for tackling this: #36989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants