Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a tab block for rendering tabs #37096

Closed
3 tasks
louwie17 opened this issue Mar 7, 2023 · 0 comments · Fixed by #37225
Closed
3 tasks

Create a tab block for rendering tabs #37096

louwie17 opened this issue Mar 7, 2023 · 0 comments · Fixed by #37225
Assignees
@joshuatf
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin.

Comments

@louwie17
Copy link
Contributor

louwie17 commented Mar 7, 2023 •
edited

Blocked by #36991

You may want to look at the navigation block or the column and columns blocks for inspiration.
And also consider if it would be worth defining a tab as a template or a pattern (template might be the better fit ).

Screenshots

Image

Design

Note: The design should be used as a more general look and feel of the component, as the design might still be change a bit. So to not get caught up in the nitty gritty.
z2spDLDAX5DbMeG4ZTMp06-fi-804%3A165896

Acceptance criteria

  • A tab block should be rendered in the product editor template
  • A tab should have a name
  • A tab should support nested sections and fields.
@louwie17 louwie17 added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: product management Related to product creation and editing. labels Mar 7, 2023
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Mar 7, 2023
@louwie17 louwie17 removed the status: awaiting triage This is a newly created issue waiting for triage. label Mar 7, 2023
@joshuatf joshuatf self-assigned this Mar 9, 2023
This was referenced Mar 10, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuatf joshuatf

Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests around product block editor tabs woocommerce/woocommerce
2 participants
@louwie17 @joshuatf