Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a product name field block #37007

Closed
3 tasks
joshuatf opened this issue Feb 28, 2023 · 1 comment · Fixed by #37132
Closed
3 tasks

Create a product name field block #37007

joshuatf opened this issue Feb 28, 2023 · 1 comment · Fixed by #37132
Assignees
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.

Comments

@joshuatf
Copy link
Contributor

joshuatf commented Feb 28, 2023

Blocked by #36991

To make testing and follow-up issues easier, we should create an initial field as a block for use in other PRs. This will make it easier to see hydrated data, verify validation, and make sure edits are persisted.

Prior art for this field can be seen in this PR.

Note that since we don't have a finalized design for this new experience, I think using the existing name field styling as is should be fine.

Screenshots

Note: the screenshot is from the POC and not the wireframe.
Image

Design

Note: The design should be used as a more general look and feel of the component, as the design might still be change a bit. So to not get caught up in the nitty gritty.
z2spDLDAX5DbMeG4ZTMp06-fi-806%3A160389

Acceptance criteria

  • A name block should be rendered in the product editor template
  • The field should store edits inside the entity data store on change (these will not be persisted in this issue)
  • Name field should roughly reflect the Figma designs
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Feb 28, 2023
@joshuatf
Copy link
Contributor Author

Estimate: 1

This can be mostly copied directly from the POC. Validation and persistence of this field will be hooked up in follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants