Adding test name block with support for entity data store #37132

joelclimbsthings · 2023-03-08T17:56:37Z

All Submissions:

Have you followed the WooCommerce Contributing guideline?
Does your code follow the WordPress' coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Adding a basic name block to the product editor, with support for the entity data store.

Closes #37007 .

How to test the changes in this Pull Request:

Checkout branch.
Enable new-product-management-experience feature flag.
Navigate to Products -> Add new.
You should see the block editor, with the name block present.
If you have redux dev tools, open them and select the core store (for some reason this is listed twice for me, and I need to select the 2nd one)
Notice when you type into the name field that the EDIT_ENTITY_RECORD action is fired.

Other information:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?
Have you included testing instructions?

FOR PR REVIEWER ONLY:

I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

github-actions · 2023-03-08T18:21:26Z

Test Results Summary

Commit SHA: ca24f9e

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 54s
E2E Tests	189	0	0	6	0	195	14m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

codecov · 2023-03-08T18:28:45Z

Codecov Report

Merging #37132 (ca24f9e) into trunk (0cf5677) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##             trunk   #37132   +/-   ##
========================================
  Coverage     46.7%    46.7%           
  Complexity   17191    17191           
========================================
  Files          429      429           
  Lines        64845    64845           
========================================
  Hits         30275    30275           
  Misses       34570    34570

Impacted Files	Coverage Δ
...ugins/woocommerce/includes/class-wc-post-types.php	`2.8% <ø> (ø)`

joelclimbsthings · 2023-03-08T21:51:23Z

packages/js/product-editor/tsconfig-cjs.json

 	"compilerOptions": {
-		"outDir": "build"
+		"outDir": "build",
+		"resolveJsonModule": true,


Need to tweak TS configuration to support importing JSON files, as there are benefits to using the standard block.json file to provide metadata.

louwie17 · 2023-03-09T09:46:21Z

packages/js/product-editor/src/utils/parse-product-to-blocks.ts

+
+	blocks.push(
+		createBlock( nameBlock.name, {
+			name: product.name,


Just curious if this logic will still be needed if we start using templates to generate the form?

@louwie17 After our conversation this morning, my thought is no (it's not needed). I believe once we have your template PR merged I can just register this block and move it to the template..? If you get that merged first, I'm glad to rebase and retool a bit. Otherwise we can migrate it in that PR or another follow-up.

Also in favor of removing this. Seems like at best we can avoid this, but worst case is we will need to parse the product and retrofit it into the hydrated template.

Louren's settings PR is now merged, and I've rebased this PR to include it. I started experimenting with loading the blocks from the post type template in d284e9b. I'm uncertain of the pattern here, and arguably this might belong in a separate PR. I can continue on Monday but let me know if you have any thoughts @louwie17

Hmm I don't think its necessary to register the template as a block (unless you saw a similar pattern in Gutenberg somewhere?)
In theory we should just be able to pass it into the setupEditor function similar to what Josh started doing here: https://github.com/woocommerce/woocommerce/pull/36921/files#diff-5fbb147f0c06b95b81afa9f70ae6db13e289b2714f4b21d041a7bd88670a1d03R106

Josh's approach is similar to Gutenberg's approach here: https://github.com/WordPress/gutenberg/blob/trunk/packages/editor/src/components/provider/index.js#L84
We may also want to make use of the useBlockEditorSettings that is being made use of there (if the call to setupEditor is not enough).

But on second thought it might help to leave this as is for now and merge it, to un-block any block field work and create a separate PR for the template support.

louwie17 · 2023-03-13T12:18:00Z

@joelclimbsthings I hope you don't mind, but I messed around with the template work and got it working in this commit: aff7ac2
So I decided to push it up right away.

mdperez86 · 2023-03-13T14:44:25Z

@joelclimbsthings and @louwie17 Good work here and also tested well to me. I'm going to merge this PR as we talked @louwie17 so we can unblock the rest of the issues the depend on this PR.

mdperez86

Good job!!!

joelclimbsthings force-pushed the add/name-block-37007 branch from 200cb32 to 78b920d Compare March 8, 2023 20:14

joelclimbsthings changed the base branch from trunk to add/initial-product-draft-37003 March 8, 2023 20:14

joelclimbsthings self-assigned this Mar 8, 2023

joelclimbsthings requested a review from a team March 8, 2023 20:15

joelclimbsthings marked this pull request as ready for review March 8, 2023 20:15

joelclimbsthings commented Mar 8, 2023

View reviewed changes

louwie17 reviewed Mar 9, 2023

View reviewed changes

Base automatically changed from add/initial-product-draft-37003 to trunk March 9, 2023 21:11

joelclimbsthings force-pushed the add/name-block-37007 branch from 6efc313 to 947b3f1 Compare March 9, 2023 21:21

joelclimbsthings mentioned this pull request Mar 9, 2023

Add section block for use in product editor #37153

Merged

9 tasks

joelclimbsthings force-pushed the add/name-block-37007 branch from 947b3f1 to d284e9b Compare March 11, 2023 01:21

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Mar 11, 2023

mdperez86 mentioned this pull request Mar 13, 2023

Add a product header component to the blocks interface #37152

Merged

9 tasks

joelclimbsthings and others added 9 commits March 13, 2023 14:49

Adding test name block with support for entity data store

4143fc4

Adding changelog

cd1ab11

Changing block.ts to block.json and amending TS config to support

66246d7

Experiment in loading blocks from settings template

e19c0e5

Enable the use of templates with the block editor

08f5e5d

Fix dependency

46d5a53

Add changelog

eb2c9db

Fix lint error and remove unused utils

0cf8eaf

Fix tests by fixing mocks

ca24f9e

louwie17 force-pushed the add/name-block-37007 branch from fdca43d to ca24f9e Compare March 13, 2023 14:03

github-actions bot added the focus: react admin [team:Ghidorah] label Mar 13, 2023

mdperez86 self-requested a review March 13, 2023 14:44

mdperez86 approved these changes Mar 13, 2023

View reviewed changes

mdperez86 merged commit 4dff6db into trunk Mar 13, 2023
30 checks passed

mdperez86 deleted the add/name-block-37007 branch March 13, 2023 14:45

github-actions bot added this to the 7.6.0 milestone Mar 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding test name block with support for entity data store #37132

Adding test name block with support for entity data store #37132

joelclimbsthings commented Mar 8, 2023 •

edited

github-actions bot commented Mar 8, 2023 •

edited

codecov bot commented Mar 8, 2023 •

edited

joelclimbsthings Mar 8, 2023

joshuatf Mar 9, 2023

louwie17 Mar 9, 2023

joelclimbsthings Mar 9, 2023 •

edited

joshuatf Mar 9, 2023

joelclimbsthings Mar 11, 2023

louwie17 Mar 13, 2023

louwie17 Mar 13, 2023

louwie17 commented Mar 13, 2023

mdperez86 commented Mar 13, 2023

mdperez86 left a comment

Adding test name block with support for entity data store #37132

Adding test name block with support for entity data store #37132

Conversation

joelclimbsthings commented Mar 8, 2023 • edited

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Other information:

FOR PR REVIEWER ONLY:

github-actions bot commented Mar 8, 2023 • edited

Test Results Summary

codecov bot commented Mar 8, 2023 • edited

Codecov Report

joelclimbsthings Mar 8, 2023

Choose a reason for hiding this comment

joshuatf Mar 9, 2023

Choose a reason for hiding this comment

louwie17 Mar 9, 2023

Choose a reason for hiding this comment

joelclimbsthings Mar 9, 2023 • edited

Choose a reason for hiding this comment

joshuatf Mar 9, 2023

Choose a reason for hiding this comment

joelclimbsthings Mar 11, 2023

Choose a reason for hiding this comment

louwie17 Mar 13, 2023

Choose a reason for hiding this comment

louwie17 Mar 13, 2023

Choose a reason for hiding this comment

louwie17 commented Mar 13, 2023

mdperez86 commented Mar 13, 2023

mdperez86 left a comment

Choose a reason for hiding this comment

joelclimbsthings commented Mar 8, 2023 •

edited

github-actions bot commented Mar 8, 2023 •

edited

codecov bot commented Mar 8, 2023 •

edited

joelclimbsthings Mar 9, 2023 •

edited