Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new stock status called "Discontinued" #10080

Closed
wants to merge 19 commits into from

Conversation

@ej52
Copy link

ej52 commented Jan 15, 2016

Add a new stock status called "Discontinued", for this simple reason.

Shop owners may want to keep the product page alive (for SEO or other purpose) but do not want to confuse shoppers and give them hope that out of stock product will be back.

Got the idea from here

@ej52 ej52 changed the title Added a new stock status called "Discontinued" Add a new stock status called "Discontinued" Jan 15, 2016
@mikejolley

This comment has been minimized.

Copy link
Member

mikejolley commented Jan 18, 2016

What would be the benefit of further complicating stock status vs just adding some content to the product page or title?

I'd also question the SEO benefit of listing no-longer available products. If I went to a store looking for something and was not able to buy it/discontinued, I wouldn't be too pleased :)

@mikejolley mikejolley modified the milestone: 2.6 Jan 18, 2016
@ej52

This comment has been minimized.

Copy link
Author

ej52 commented Jan 18, 2016

If I went to a store looking for something and was not able to buy it/discontinued, I wouldn't be too pleased :)

I would rather have a product show "discontinued", than going to a bookmarked product and getting a 404 or being redirecting to something I was not interested in.

There are cases where products may have technical documents or firmware / software relating to the product attached and will be discontinued.

Setting the product to "out of stock" will give customers a false hope that the the product may become available again. Having a "discontinued" status here will take any hope of the product coming back "in stock" away.

In cases like this you would not want to modify the title and/or slug, as customers may have bookmarked the page to refer to later for updates etc.

Looking at it now I may have jumped the gun on submitting the pull request, as there is room for improvement on adding a discontinued status.

eg. Hide out of stock items from the catalog would hide the discontinued products currently due to is_in_stock returning false.

@claudiosanches

This comment has been minimized.

Copy link
Member

claudiosanches commented Jan 18, 2016

I need to say... I'm not a fan of this code...

But Discontinued it's a valid of ItemAvailability: https://schema.org/ItemAvailability

@mikejolley we can add this terms or added a away for plugins add. But I don't want to merge this code, need to be refactored.

@ej52

This comment has been minimized.

Copy link
Author

ej52 commented Jan 19, 2016

@claudiosmweb Understandable, the changes were made in a rush and looking over it again it would need a lot of refactoring.

I think adding a few new hooks would be better in the long run to allow for adding custom stock statuses, will close this pull request and implement custom status hooks instead.

@ej52 ej52 closed this Jan 19, 2016
@ej52 ej52 deleted the ej52:patch-1 branch Jan 19, 2016
@mikejolley mikejolley removed this from the 2.6 milestone Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.