Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates readme.txt #23267

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Updates readme.txt #23267

merged 1 commit into from
Apr 24, 2019

Conversation

MarinaWoo
Copy link
Contributor

@MarinaWoo MarinaWoo commented Apr 10, 2019 •
edited by rodrigoprimo
Loading

This includes changes to the readme.txt file to update the listing for WooCommerce on the .org repo.

This PR is copy only. Images to be supplied by @jameskoster (header and screenshots).

@MarinaWoo
Update readme.txt
9bfcb82 
This includes changes to the readme.txt file to update the listing for WooCommerce on the .org repo.

Images still to be supplied by Jay Koster (header and screenshots).
@MarinaWoo MarinaWoo added the type: enhancement The issue is a request for an enhancement. label Apr 10, 2019
@mikejolley mikejolley added this to the 3.6.0 milestone Apr 12, 2019
@mikejolley
Copy link
Member

@MarinaWoo @jameskoster @timmyc Is this for 3.6 or not? If so it needs review/screenshots asap.

@MarinaWoo
Copy link
Contributor Author

Up to @jameskoster – screenshots are on P2.

@rodrigoprimo rodrigoprimo added the status: in progress This is being worked on. label Apr 15, 2019
@timmyc
Copy link
Contributor

timmyc commented Apr 17, 2019

Since we didn't get to this in time - my vote is to update outside of the 3.6 release or just do the updates in 3.6.1

@mikejolley I'm assuming that it is okay to manually push updates to the readme in svn if needed?

@MarinaWoo
Copy link
Contributor Author

Ye, the screenshots are ready – but we lost a few days here and are now right on 3.6 release so will circle back next week.

@mikejolley mikejolley removed this from the 3.6.0 milestone Apr 18, 2019
@MarinaWoo
Copy link
Contributor Author

@timmyc @mikejolley Following up on this.

The images have been ready a while: https://cloudup.com/cqNSORP07nl CC @jameskoster :)

@timmyc timmyc added this to the 3.6.2 milestone Apr 24, 2019
@mikejolley mikejolley added cherry picked and removed status: in progress This is being worked on. labels Apr 24, 2019
@mikejolley
Copy link
Member

@timmyc @peterfabian Cherry picked this into release branch but the images will need uploading and this will need merging to master once 3.6.2 is out.

@claudiosanches claudiosanches mentioned this pull request Apr 24, 2019
Merged
@woocommercebot woocommercebot added status: approved and removed cherry picked type: enhancement The issue is a request for an enhancement. labels Apr 24, 2019
@claudiosanches claudiosanches merged commit 936de39 into master Apr 24, 2019
@claudiosanches claudiosanches deleted the updates-readme.txt branch April 24, 2019 20:41
@kloon kloon mentioned this pull request Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiosanches claudiosanches claudiosanches approved these changes

@jameskoster jameskoster Awaiting requested review from jameskoster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@MarinaWoo @mikejolley @timmyc @claudiosanches @rodrigoprimo @woocommercebot