Update system status info about WC Admin.

[peterfabian]

The check now also tests whether wc admin is active to prevent notice about undefined constant when running on WP 5.2 and older, or with inactive WC Admin.

All Submissions:

• Have you followed the WooCommerce Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes # .

How to test the changes in this Pull Request:

1. Get a testing machine with WP 5.2

2. Install WC 4.0-rc.1

3. Go to system status and observe the error
   

4. apply this branch

5. check again, it should show the WC Admin is inactive:
   

6. Update to WP 5.3

7. Check that WC Admin becomes active:
   

8. Try installing & activating the WC Admin plugin, check that the version and path are correctly pointing to the plugin:
   

9. Deactivate the plugin, it should, again, show the included package info.

10. Use a snippet to deactivate WC Admin package (add_filter( 'woocommerce_admin_disabled', '__return_true' ); to wc-core-functions.php)

11. It should show Inactive package in the system status report.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?

Changelog entry

Fix - System status report should correctly identify inactive package.

[peterfabian]

cc @rrennick to check the logic for WC Admin.

[rodrigoprimo]

Looks good to me and I could confirm that it fixes the warning message. I left a comment with a nitpick suggestion.

Besides that, related to the part of the code that is changed in this PR but not directly related to this PR, I found a bit confusing that when WooCommerce Admin is inactive we show the string "Inactive" together with the version number and package path in green. It took me a while to realize what was the difference between when the plugin is inactive or active. I imagine that changing the font color to red is too drastic, but maybe we could change it to black and display a X when the plugin is inactive? That is what we do, for example, when there is no child theme installed. I'm not sure if we want to address this in this release cycle.

[rodrigoprimo]

Just a nitpick, but what if instead of using this generic name $path, we use a more specific name like $wc_admin_path. This way, we don't need to worry about other places that are using the same variable name, and also, we don't need to add a phpcs:ignore comment whenever we use this variable.

[peterfabian]

Agreed, wanted to do that already, but then wasn't sure if I should rename the vars in other sections. Let's update at least this one.

[rrennick]

to check the logic for WC Admin.

@peterfabian Looks good.

[peterfabian]

I found a bit confusing that when WooCommerce Admin is inactive we show the string "Inactive" together with the version number and package path in green. It took me a while to realize what was the difference between when the plugin is inactive or active. I imagine that changing the font color to red is too drastic, but maybe we could change it to black and display a X when the plugin is inactive? That is what we do, for example, when there is no child theme installed.

I was wondering about changing it, but haven't noticed we have this neutral option available. Updated to the below in a9e262c:

[rodrigoprimo]

Thanks for the changes.