New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WooCommerce Blocks package to 3.4.0 #27676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I ignored the testing instructions for the Checkout and Cart blocks as they are not available when using the version of woocommerce-blocks that is bundled with core (cc @juliaamosova and @tammullen in case this is something that we need to remove when creating the testing instructions for 4.6.0).
I had some trouble following some of the testing instructions. Nothing that should block this PR in my opinion but documenting here just in case it is useful:
Broken link for "No Products" placeholder
I don't see a link in the output of the All Products block when the store has no products. I only see an exclamation mark icon and some text.
All Products block: Can now customize text size, color and alignment in Product Title child block.
I don't see an option to centralize the title, and changing the heading level doesn't seem to have any effect.
Thanks for going through this Rodrigo!
I just tried too and saw the same thing for both what's included in Core and with the feature plugin active. I agree this isn't blocking for this update but it does look like this a regression from the fix added in #2961. I created woocommerce/woocommerce-blocks#3158 for addressing this. @juliaamosova or @tammullen testing instructions can exclude these particular steps.
Ahh sorry @rodrigoprimo, it looks like this also is something specific to the feature plugin for now. As a general observation, recently I made a note in our release checklist to ensure testing notes differentiate between what is included in WooCommerce core and what is in the feature plugin to make it clearer when code is included as a package in WooCommerce core. |
Thanks for pointing out @rodrigoprimo and for your follow-up @nerrad! Noted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, also considering Rodrigo's report.
This pull updates the WooCommerce Blocks plugin to 3.4.0. It includes changes from WooCommerce Blocks 3.2.0-3.4.0 and intended to target WooCommerce 4.6.0 for release.
Details from all the different releases included in this pull:
Blocks 3.2.0
Blocks 3.3.0
Blocks 3.4.0
Changelog entry