Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export sass vars to css var #28709

Merged
merged 2 commits into from Jan 15, 2021
Merged

Export sass vars to css var #28709

merged 2 commits into from Jan 15, 2021

Conversation

kevinruscoe
Copy link
Contributor

@kevinruscoe kevinruscoe commented Jan 2, 2021

All Submissions:

Changes proposed in this Pull Request:

Simply exports the SASS variables in _variables as CSS variables, so aid with front-end development.

Closes #28707.

How to test the changes in this Pull Request:

  1. Add h1 {color: var(--wc-green) !important;} to your stylesheet to see the h1 header be the WooComms green colour.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

Changelog entry

Enhancement - Export SASS variables as CSS variables.

assets/css/_variables.scss Outdated Show resolved Hide resolved
assets/css/_variables.scss Outdated Show resolved Hide resolved
assets/css/_variables.scss Outdated Show resolved Hide resolved
assets/css/_variables.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@claudiosanches claudiosanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@claudiosanches claudiosanches added this to the 5.0.0 milestone Jan 15, 2021
@claudiosanches claudiosanches merged commit 55cfa09 into woocommerce:master Jan 15, 2021
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Jan 15, 2021
@claudiosanches claudiosanches removed the release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: add changelog Mark all PRs that have not had their changelog entries added. [auto]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CSS variables from _variables.scss values
3 participants