Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offsets not calculated correctly sometimes on select2 dropdowns … #29397

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

roykho
Copy link
Member

@roykho roykho commented Mar 16, 2021

closes #29163

All Submissions:

Changes proposed in this Pull Request:

Closes #29163 #28996

How to test the changes in this Pull Request:

  1. Install/activate jQuery Migrate Plugin so you can easily switch the two different jQuery versions for testing.
  2. Add an attributes filter widget to your shop. Use Dropdown as display type.
  3. Go to the shop page and click on the Select2 dropdown and ensure the dropdown shows correctly aligned and that you can select any of the attributes listed. Select an attribute and let page reload.
  4. Click on the dropdown again and ensure it expands correctly and you are able to select other attributes as well.
  5. Do the same test with and without the admin toolbar visible. You can change this in your user settings.
  6. Also do the same tests (3 to 6) with the dropdown going upwards when not enough room to show on the bottom.
  7. Now do the same tests again (3 to 6) with using older jQuery version by changing the settings in jQuery Migrate plugin. Ensure all is looking nice.
  8. Also check that the dropdown is showing nicely in checkout page (country selection).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Note

In older legacy jQuery version the dropdown in the country selection has a slight pixel or two off on the right side container. But that was always there so it isn't fixed by this PR.

Changelog entry

  • Fix - offsets not calculated correctly sometimes on select2 dropdowns causing usability issues.

@roykho roykho requested review from a team and Konamiman and removed request for a team March 16, 2021 14:51
@Konamiman Konamiman merged commit 7ba4823 into trunk Mar 17, 2021
@Konamiman Konamiman deleted the fix/issue-29163 branch March 17, 2021 08:38
@woocommercebot woocommercebot added release: add changelog Mark all PRs that have not had their changelog entries added. [auto] release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Mar 17, 2021
@Konamiman Konamiman added this to the 5.2.0 milestone Mar 17, 2021
@Konamiman Konamiman added release: highlight Issues that have a high user impact and need to be discussed/paid attention to. and removed release: add changelog Mark all PRs that have not had their changelog entries added. [auto] labels Mar 18, 2021
@zhongruige zhongruige added testing instructions added and removed release: add testing instructions PRs that have not had testing instructions added to the wiki. [auto] labels Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: highlight Issues that have a high user impact and need to be discussed/paid attention to.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP 5.6.1 Select2 issue
4 participants