Delete coupons instead of trashing them #30696
Conversation
rrennick
added
category: E2E
package: @woocommerce/e2e-core-tests
rrennick
force-pushed
the
fix/30371
branch
2 times, most recently
from
369b935
to
ce1b1a6
Compare
There was a problem hiding this comment.
Thanks for working on this @rrennick! These ran great for me locally.
Only a few minor comments on text changes and a question. Otherwise this looks good to merge once those are addressed.
tests/e2e/utils/CHANGELOG.md
Outdated
| ## Added | ||
|
|
||
| - `utils.waitForTimeout( delay )` pause processing for `delay` milliseconds | ||
| - `AdminEdit`, `OrderEdit` classes with utility functions for the respctive edit screens |
There was a problem hiding this comment.
Minor typo:
| - `AdminEdit`, `OrderEdit` classes with utility functions for the respctive edit screens | |
| - `AdminEdit`, `OrderEdit` classes with utility functions for the respective edit screens |
There was a problem hiding this comment.
Nice catch, fixed in 5ccf3a5
tests/e2e/utils/README.md
Outdated
| @@ -153,6 +153,34 @@ This package provides support for enabling retries in tests: | |||
| | `updatePaymentGateway`| `paymentGatewayId`, `payload` | Update a payment gateway | | |||
| | `getSystemEnvironment` | | Get the current environment from the WooCommerce system status API. | |||
|
|
|||
| ### Classes | |||
|
|
|||
| The package includes the following page specific utility classes | |||
There was a problem hiding this comment.
Just a minor suggestion to add a colon at the end:
| The package includes the following page specific utility classes | |
| The package includes the following page specific utility classes: |
| await expect( page ).toMatchElement( | ||
| '#woocommerce-order-notes .note_content', | ||
| { | ||
| text: 'Order status changed from Pending payment to Processing.', |
There was a problem hiding this comment.
Do we always expect the Processing status and note status text to be present (e.g., Order status changed from Pending payment to Processing. ) when using verifyPublish() here, or do we need to make them more dynamic?
There was a problem hiding this comment.
@zhongruige Thanks for pointing this out. That test is specific to our test flow so I moved that test to there. That eliminated the need for the OrderEdit class so I removed it.
This is ready for another review.
|
Hi @zhongruige, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
Changes proposed in this Pull Request:
This PR updates the new coupon test to delete the created coupon instead of trashing it. It adds a
waitForTimeoututility function andAdminEdit,OrderEditutility classes.Closes #30371 .
How to test the changes in this Pull Request: