-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add promoted card to in-App marketplace page #30861
Conversation
I'm currently having trouble getting the API request to work locally with my Woo Core development environment site – I'm getting |
@andfinally I'm testing from the test customer site if that helps 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @corsonr! Everything looks good to me except for the test site URL that accidentally made its way to the commit, we'll need to replace it with the original feed before merging. Other than that, the cards are looking great on all screen sizes 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @corsonr!
It works like a charm! 🍀
I've made it as a comment rather than approval to ask you to apply Maria's and mine suggestions first.
…the changes in this branch.
…ddons::get_star_class`.
Hi @Konamiman, I've set the base to |
…App Marketplace template page, which was accidentally omitted when fixing conflicts.
Hi @Konamiman, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
Merged into |
Additional pull request to incorporate these changes in WooCommerce 6.0: #31090 |
All Submissions:
Changes proposed in this Pull Request:
The search on
WooCommerce > Marketplace
page that shows product from the WooCommerce.com marketplace as cards. During previous re-design phase we added updated product cards in #30410.This PR adds a new style of "promoted" product cards by:
Closes Automattic/woocommerce.com#10885
Screenshots
How to test the changes in this Pull Request:
includes/admin/class-wc-admin-addons.php
.$featured = get_transient( 'wc_addons_featured' );
to bypass the transient check:https://woocommerce.com/wp-json/wccom-extensions/2.0/featured' . $parameter_string
to point to our mock WCCOM featured API data:https://gist.githubusercontent.com/corsonr/6ac9a36583dce3a2d2d9e97f4ddf7847/raw/60a38e52de705566bdb74b2059d6acc6a086379b/featured.json
.the headers could have to be removed from the
wp_safe_remote_get
call.'https://woocommerce.com/wp-json/wccom-extensions/1.0/search' . $parameters,
to point to another mock JSON endpoint:https://gist.githubusercontent.com/andfinally/cdea0c85da10bc037dad6aaa8bf28d0e/raw/search.json
.wp-admin/admin.php?page=wc-addons§ion=_featured
.Discover our favorites
group you should see the two new styles of card shown in this screenshot:wp-admin/admin.php?page=wc-addons§ion=marketing-extensions
or search results page. You should see the two styles of card shown here at the top:Other information:
Changelog entry
FOR PR REVIEWER ONLY: