Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promoted card to in-App marketplace page #31090

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

Konamiman
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This pull request incorporates the changes of #30861 and #31002, that were merged directly into the release/5.9 branch.

See the original pull requests for testing instructions and changelog entry.

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Changed name of transient for v2.0 of in-app marketplace featured page
content, so sites upgrading to WooCommerce 5.9 will get the correct
data for the new version of the page.
Copy link
Contributor

@jeffstieler jeffstieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code seems the same as the two PRs it combines. 👍

@jeffstieler jeffstieler merged commit d64c449 into trunk Nov 9, 2021
@jeffstieler jeffstieler deleted the add/promoted-card-to-in-app-marketplace branch November 9, 2021 15:02
@github-actions github-actions bot added this to the 6.0.0 milestone Nov 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

Hi @jeffstieler, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the status: needs changelog label
  • Add the status: needs testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants