-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic price_suffix
in in-app marketplace
#31026
Conversation
… allowing prices per month. This was added in #30840, but was accidentally omitted when we fixed conflicts.
price_suffix
in in-app marketplace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a minor tweak to satisfy linting rules 👍
Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(Triggered a re-run of a couple of checks, however the failures were likely unrelated to this change.)
Hi @barryhughes, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
Great! Thanks for the review Barry. |
All Submissions:
Changes proposed in this Pull Request:
Adds support for a
price_suffix
property in each product in the WooCommerce.com search and featured endpoints, which provide the data for the product cards in the in-app marketplace. This will allow us to list products whose fees are per month.How to test the changes in this Pull Request:
Note for GlobalStep testers
The required data changes for this PR haven't been implemented on WooCommerce.com yet, and the test below requires using the test data in a GitHub gist. For now, it's fine if we simply continue to see "per year" on the prices of products in the Marketplace, for example
$29.00 per year
, where the product is not free.Test using dummy data
wp-content/plugins/woocommerce/plugins/woocommerce/includes/admin/class-wc-admin-addons.php:143
to point to this gist with test data:https://gist.githubusercontent.com/andfinally/84015c40afc8dc628f2496c9c4faf0f8/raw/search.json
.wp-admin/admin.php?page=wc-addons§ion=payment-gateways
.Other information:
Changelog entry
Add - Support for dynamic price period in in-app marketplace product cards.
FOR PR REVIEWER ONLY: