Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the default payment suggestions when woocommerce_show_marketplace_suggestions is set to no #34083

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Use the default payment suggestions when woocommerce_show_marketplace_suggestions is set to no #34083

merged 4 commits into from
Jul 28, 2022

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jul 27, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes #33958 .

This PR adds a new optional argument force_default_suggestions to the payment suggestions endpoint.

When the argument is set to true, the endpoint returns the default payment suggestions when both woocommerce_show_marketplace_suggestions and woocommerce_setting_payments_recommendations_hidden are set to no

It fixes the blank page described in the original issue.

How to test the changes in this Pull Request:

  1. Start with a fresh install and complete OBW without installing any plugins in the business step.
  2. Set woocommerce_show_marketplace_suggestions option to no
  3. Go to WooCommerce -> Home and choose Set up payments task.
  4. Confirm the suggestions are rendered as expected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@moon0326
Support force_default_suggestions argument
89331da
@moon0326
Use force_default_suggestions
2445f6d
@moon0326
Support force_default_suggestions argument -- returns the default pay…
69819d9 
…ment suggestions when both woocommerce_show_marketplace_suggestions and woocommerce_setting_payments_recommendations_hidden options are set to no
@moon0326
Add changelog
8aae557
@moon0326 moon0326 requested a review from a team July 27, 2022 20:01
@github-actions github-actions bot added focus: react admin package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 27, 2022
@moon0326 moon0326 mentioned this pull request Jul 27, 2022
Closed
5 tasks
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 8aae557

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 49s
E2E Tests185001018612m 59s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@moon0326 moon0326 marked this pull request as draft July 27, 2022 20:33
@moon0326 moon0326 marked this pull request as ready for review July 27, 2022 21:26
ilyasfoo
ilyasfoo approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, LGTM! Thanks for working on this fix, @moon0326! 🚢 🚢

@moon0326 moon0326 merged commit dfa8d01 into trunk Jul 28, 2022
@moon0326 moon0326 deleted the fix/33958-blank-payment-task-when-marketplace-suggestion-is-disabled branch July 28, 2022 04:02
@github-actions github-actions bot added this to the 6.9.0 milestone Jul 28, 2022
@github-actions
Copy link
Contributor

Hi @moon0326, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

jacob-sewell pushed a commit that referenced this pull request Jul 29, 2022
@moon0326 @jacob-sewell
Use the default payment suggestions when woocommerce_show_marketplace…
d7e2948 
…_suggestions is set to no (#34083)

* Support force_default_suggestions argument

* Use force_default_suggestions

* Support force_default_suggestions argument -- returns the default payment suggestions when both woocommerce_show_marketplace_suggestions and woocommerce_setting_payments_recommendations_hidden options are set to no

* Add changelog
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Assignees
No one assigned
Labels
package: @woocommerce/data issues related to @woocommerce/data plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.

Blank payment task when user disable marketplace suggestions
2 participants
@moon0326 @ilyasfoo