New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #35232
Fix typo #35232
Conversation
What's a guy gotta do to get this reviewed? It's a personal pet peeve of mine when products get the noun and verb wrong here. |
@Benunc Thanks for the bump and sorry for the delay. It looks like this one slipped through the cracks. I'll add a changelog entry so it's eligible for merge after the tests run. |
@Benunc Can you merge the latest trunk into this PR so it will pass tests? |
Hi , @woocommerce/solaris Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
@woocommerce/solaris Pinging you for a review as I had to update the E2E tests for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing and updates look good. Thanks!
"Log out" is a verb
"logout" is a noun.
This link should be an action. So it's the verb form.
All Submissions:
Changes proposed in this Pull Request:
Simple grammar fix
Other information:
pnpm changelog add --filter=<project>
?FOR PR REVIEWER ONLY: