Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #35232

Merged
merged 5 commits into from May 5, 2023
Merged

Fix typo #35232

merged 5 commits into from May 5, 2023

Conversation

Benunc
Copy link
Contributor

@Benunc Benunc commented Oct 20, 2022

"Log out" is a verb
"logout" is a noun.

This link should be an action. So it's the verb form.

All Submissions:

Changes proposed in this Pull Request:

Simple grammar fix

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

"Log out" is a verb
"logout" is a noun. 

This link should be an action. So it's the verb form.
@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Oct 20, 2022
@Benunc
Copy link
Contributor Author

Benunc commented Apr 27, 2023

What's a guy gotta do to get this reviewed? It's a personal pet peeve of mine when products get the noun and verb wrong here.

@rrennick
Copy link
Contributor

@Benunc Thanks for the bump and sorry for the delay. It looks like this one slipped through the cracks. I'll add a changelog entry so it's eligible for merge after the tests run.

@rrennick
Copy link
Contributor

@Benunc Can you merge the latest trunk into this PR so it will pass tests?

@github-actions github-actions bot added the focus: e2e tests Issues related to e2e tests label May 2, 2023
@rrennick rrennick self-requested a review May 4, 2023 19:23
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Hi , @woocommerce/solaris

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@rrennick rrennick requested a review from a team May 5, 2023 17:43
@rrennick
Copy link
Contributor

rrennick commented May 5, 2023

@woocommerce/solaris Pinging you for a review as I had to update the E2E tests for this PR.

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and updates look good. Thanks!

@lanej0 lanej0 merged commit 6fdddd2 into woocommerce:trunk May 5, 2023
18 of 19 checks passed
@github-actions github-actions bot added this to the 7.8.0 milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants