Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #35232

Merged
merged 5 commits into from May 5, 2023
Merged

Fix typo #35232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e1ec24
Fix typo
Benunc Oct 20, 2022
04da2c8
Add changelog file
rrennick Apr 27, 2023
ac71b90
Merge branch 'trunk' into Benunc-patch-1
May 1, 2023
58bf728
update E2E tests for text change
May 2, 2023
bca6c30
update unit test for text change
May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/pr-35232
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

fix logout vs log out typo
2 changes: 1 addition & 1 deletion plugins/woocommerce/includes/wc-account-functions.php
View file
Open in desktop
Expand Up @@ -102,7 +102,7 @@ function wc_get_account_menu_items() {
'edit-address' => _n( 'Address', 'Addresses', ( 1 + (int) wc_shipping_enabled() ), 'woocommerce' ),
'payment-methods' => __( 'Payment methods', 'woocommerce' ),
'edit-account' => __( 'Account details', 'woocommerce' ),
'customer-logout' => __( 'Logout', 'woocommerce' ),
'customer-logout' => __( 'Log out', 'woocommerce' ),
);

// Remove missing endpoints.
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/e2e-pw/tests/shopper/checkout-create-account.spec.js
View file
Open in desktop
Expand Up @@ -169,7 +169,7 @@ test.describe( 'Shopper Checkout Create Account', () => {
await expect( page.locator( 'h1.entry-title' ) ).toContainText(
'My account'
);
await page.click( 'text=Logout' );
await page.click( 'text=Log out' );
// sign in as admin to confirm account creation
await page.fill( '#username', admin.username );
await page.fill( '#password', admin.password );
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/e2e-pw/tests/shopper/my-account-create-account.spec.js
View file
Open in desktop
Expand Up @@ -78,7 +78,7 @@ test.describe( 'Shopper My Account Create Account', () => {
await expect( page.locator( 'h1.entry-title' ) ).toContainText(
'My account'
);
await expect( page.locator( 'text=Logout' ) ).toBeVisible();
await expect( page.locator( 'text=Log out' ).first() ).toBeVisible();

await page.goto( 'my-account/edit-account/' );
await expect( page.locator( '#account_email' ) ).toHaveValue(
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/e2e-pw/tests/shopper/my-account.spec.js
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ test.describe( 'My account page', () => {
page.locator(
'.woocommerce-MyAccount-navigation-link--customer-logout'
)
).toContainText( 'Logout' );
).toContainText( 'Log out' );
} );

for ( let i = 0; i < pages.length; i++ ) {
Expand Down
2 changes: 1 addition & 1 deletion plugins/woocommerce/tests/legacy/unit-tests/account/functions.php
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ public function test_wc_get_account_menu_items() {
'downloads' => 'Downloads',
'edit-address' => 'Addresses',
'edit-account' => 'Account details',
'customer-logout' => 'Logout',
'customer-logout' => 'Log out',
),
wc_get_account_menu_items()
);
Expand Down