Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flakey settings API test. #35338

Merged
merged 1 commit into from Oct 26, 2022
Merged

Skip flakey settings API test. #35338

merged 1 commit into from Oct 26, 2022

Conversation

lanej0
Copy link
Contributor

@lanej0 lanej0 commented Oct 26, 2022

All Submissions:

Changes proposed in this Pull Request:

Skips a flakey API test for now, that's blocking CI based on discussion in #35337

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 26, 2022
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 9d4c122

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests23200302350m 46s
E2E Tests186006019214m 47s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick turnaround on this @lanej0!

These ran great for me locally and all passed in the pipeline too:

Screen Shot 2022-10-26 at 13 04 59

@zhongruige zhongruige merged commit c72122a into trunk Oct 26, 2022
@zhongruige zhongruige deleted the fix/skip-failing-api-test branch October 26, 2022 19:07
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 26, 2022
@github-actions
Copy link
Contributor

Hi @zhongruige, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants