Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert setting up permalinks in PW global setup #35337

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Conversation

MrJnrman
Copy link
Contributor

@MrJnrman MrJnrman commented Oct 26, 2022

All Submissions:

Changes proposed in this Pull Request:

Reverting the changes introduced in #35282.

That PR was a workaround for a permissions bug with wp-env that wouldn't allow you to update the permalink structure using wp-cli. Reference: WordPress/gutenberg#28201

My solutions was to use Playwrights global setup instead of wp-cli which tested great on my MAC, but while using this approach in another project, I realized that this does not work on Linux. Since this code runs in CI, these changes won't have the desired effect, so its best to revert and wait until the issue referenced above is resolved.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 26, 2022
@MrJnrman MrJnrman self-assigned this Oct 26, 2022
@MrJnrman MrJnrman requested a review from a team October 26, 2022 17:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Test Results Summary

Commit SHA: 3050e47

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests23200302350m 50s
E2E Tests186006019216m 3s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the test suite without any issues. 👍🏼

@lanej0
Copy link
Contributor

lanej0 commented Oct 26, 2022

Your changes definitely didn't cause the failure, but there is an API test failing (I tried re-running it) so merging is blocked. The test is also failing locally.

@zhongruige
Copy link
Contributor

Your changes definitely didn't cause the failure, but there is an API test failing (I tried re-running it) so merging is blocked. The test is also failing locally.

Looping in @nigeljamesstevenson as I wonder if this may be a slightly flaky test when running these, as we just merged in the settings API tests, which passed locally and in the pipeline: #35253

@lanej0
Copy link
Contributor

lanej0 commented Oct 26, 2022

@zhongruige @nigeljamesstevenson -- looks like it also failed on this PR but that was merged anyhow. There's one other open PR with that and some unit tests failing.

I tried re-running again, but still had a failure. Okay to skip this test for now, just to make sure that things aren't blocked? If so, I'll draw up a PR.

@zhongruige
Copy link
Contributor

zhongruige commented Oct 26, 2022

@zhongruige @nigeljamesstevenson -- looks like it also failed on this PR but that was merged anyhow. There's one other open PR with that and some unit tests failing.

I tried re-running again, but still had a failure. Okay to skip this test for now, just to make sure that things aren't blocked? If so, I'll draw up a PR.

Sounds good, let's skip that one for now so we can investigate further so we aren't blocking PRs. Feel free to assign me to review @lanej0 and I'll hop on it once I see it come in.

@lanej0 lanej0 mentioned this pull request Oct 26, 2022
8 tasks
@lanej0 lanej0 merged commit bfe0e95 into trunk Oct 26, 2022
@lanej0 lanej0 deleted the revert/setup-permalinks branch October 26, 2022 19:36
@github-actions github-actions bot added this to the 7.2.0 milestone Oct 26, 2022
@github-actions
Copy link
Contributor

Hi @lanej0, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants