-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert setting up permalinks in PW global setup #35337
Conversation
Test Results SummaryCommit SHA: 3050e47
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the test suite without any issues. 👍🏼
Your changes definitely didn't cause the failure, but there is an API test failing (I tried re-running it) so merging is blocked. The test is also failing locally. |
Looping in @nigeljamesstevenson as I wonder if this may be a slightly flaky test when running these, as we just merged in the settings API tests, which passed locally and in the pipeline: #35253 |
@zhongruige @nigeljamesstevenson -- looks like it also failed on this PR but that was merged anyhow. There's one other open PR with that and some unit tests failing. I tried re-running again, but still had a failure. Okay to skip this test for now, just to make sure that things aren't blocked? If so, I'll draw up a PR. |
Sounds good, let's skip that one for now so we can investigate further so we aren't blocking PRs. Feel free to assign me to review @lanej0 and I'll hop on it once I see it come in. |
Hi @lanej0, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Reverting the changes introduced in #35282.
That PR was a workaround for a permissions bug with
wp-env
that wouldn't allow you to update the permalink structure usingwp-cli
. Reference: WordPress/gutenberg#28201My solutions was to use Playwrights global setup instead of
wp-cli
which tested great on my MAC, but while using this approach in another project, I realized that this does not work on Linux. Since this code runs in CI, these changes won't have the desired effect, so its best to revert and wait until the issue referenced above is resolved.Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: