-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add/a2p product variations api-core-tests #35355
add/a2p product variations api-core-tests #35355
Conversation
Test Results SummaryCommit SHA: 68063d2
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @nigeljamesstevenson!
Couple comments we need to update.
Side note, this file is getting quite long. We should look into what it might take to break this out into smaller files so it's easier to read through what is being tested and update accordingly. Nothing we need to do on this PR, but we'll want to start thinking about it, I think.
plugins/woocommerce/tests/api-core-tests/tests/products/products-crud.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @nigeljamesstevenson! These ran and tested great for me locally:
Hi @zhongruige, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
All Submissions:
Changes proposed in this Pull Request:
Update playwright api-core-tests for shipping crud operations
Closes 362-gh-woocommerce/woocommerce-quality .
How to test the changes in this Pull Request:
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: