Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/a2p product variations api-core-tests #35355

Merged

Conversation

nigeljamesstevenson
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Update playwright api-core-tests for shipping crud operations

Closes 362-gh-woocommerce/woocommerce-quality .

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Pull down the code
  2. Navigate to woocommerce/plugins/woocommerce
  3. Execute tests with pnpm test:api-pw
  4. All tests including the new product variations tests should execute and pass successfully

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Oct 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2022

Test Results Summary

Commit SHA: 68063d2

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25400302571m 8s
E2E Tests186006019216m 31s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @nigeljamesstevenson!

Couple comments we need to update.

Side note, this file is getting quite long. We should look into what it might take to break this out into smaller files so it's easier to read through what is being tested and update accordingly. Nothing we need to do on this PR, but we'll want to start thinking about it, I think.

Copy link
Contributor

@zhongruige zhongruige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this @nigeljamesstevenson! These ran and tested great for me locally:

Screen Shot 2022-11-01 at 07 49 32

@zhongruige zhongruige merged commit 9a7a75f into trunk Nov 1, 2022
@zhongruige zhongruige deleted the add/A2P-create-product-variations-crud-api-core-tests branch November 1, 2022 13:55
@github-actions github-actions bot added this to the 7.2.0 milestone Nov 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Hi @zhongruige, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants