Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the stacked layout in the Products Task experiment #35611

Merged
merged 3 commits into from Nov 17, 2022

Conversation

adrianduffell
Copy link
Contributor

@adrianduffell adrianduffell commented Nov 17, 2022

All Submissions:

Changes proposed in this Pull Request:

Deploys the stacked layout in the Products Task experiment.

This is a quick change in time for the 7.2 code freeze to deploy the stacked layout in the Products Task experiment by always returning it as the chosen layout. A follow-up PR will be made to cleanup the experiment code completely.

Screen Shot 2022-11-17 at 16 14 33

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

On a new install,

  1. Click "Add Products" from the task list.
  2. See that the new stacked layout screen is shown (compare to screenshot above).
  3. Check the accordion functionality works by clicking "View more product types".
  4. Click the "Physical product" list item.
  5. See that the "New Product " screen is shown and is pre-filled to a "simple product" type.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@adrianduffell adrianduffell requested review from a team, ilyasfoo and moon0326 November 17, 2022 08:19
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

Test Results Summary

Commit SHA: 61d7ea8

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests26000202620m 59s
E2E Tests186006019213m 29s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

ilyasfoo
ilyasfoo previously approved these changes Nov 17, 2022
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well, thanks for working on this @adrianduffell!

I have a minor comment for removing import { loadExperimentAssignment } from '@woocommerce/explat'; import, but that's nitpicky. Feel free to merge!

@adrianduffell
Copy link
Contributor Author

Thanks @ilyasfoo ! I've removed the import now in 61d7ea8.

@ilyasfoo ilyasfoo self-requested a review November 17, 2022 09:11
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants