Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy the stacked layout in the Products Task experiment #35611

Merged
merged 3 commits into from Nov 17, 2022
Merged

Deploy the stacked layout in the Products Task experiment #35611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d5036
Deploy stacked layout in product task experiment
adrianduffell Nov 17, 2022
a6f03c0
Add changelog
adrianduffell Nov 17, 2022
61d7ea8
Remove unused import
adrianduffell Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 2 additions & 15 deletions ...ocommerce-admin/client/tasks/fills/experimental-products/use-product-layout-experiment.ts
View file
Open in desktop
Expand Up @@ -2,25 +2,12 @@
* External dependencies
*/
import { useState, useEffect } from '@wordpress/element';
import { loadExperimentAssignment } from '@woocommerce/explat';

type Layout = 'control' | 'card' | 'stacked';

export const getProductLayoutExperiment = async (): Promise< Layout > => {
const [ cardAssignment, stackedAssignment ] = await Promise.all( [
loadExperimentAssignment( `woocommerce_products_task_layout_card_v3` ),
loadExperimentAssignment(
`woocommerce_products_task_layout_stacked_v3`
),
] );
// This logic may look flawed as in both looks like they can be assigned treatment at the same time,
// but in backend we segment the experiments by store country, so it will never be.
if ( cardAssignment?.variationName === 'treatment' ) {
return 'card';
} else if ( stackedAssignment?.variationName === 'treatment' ) {
return 'stacked';
}
return 'control';
// Deploy the stacked layout. Todo: cleanup the experiment code.
return 'stacked';
};

export const isProductTaskExperimentTreatment =
Expand Down
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/fix-deploy-stacked-products-task
View file
Open in desktop
@@ -0,0 +1,4 @@
Significance: minor
Type: update

Update products task list UI