-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Create a new campaign" modal #36130
Add "Create a new campaign" modal #36130
Conversation
@nima-karimi , we need another API to get the list of campaign types when users want to create a new campaign. See |
@shivanarrthine , let me know what you think about the way I implement the modal. I try to stay close to the original design but without the borders. You can make the change in Figma and I can change the implementation accordingly. |
Test Results SummaryCommit SHA: c89b281
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Thanks for raising this, @ecgan. I'm good with the change, although I wonder if it's possible to add a divider between the sections to provide some structure to the content. (quick mockup below) Also, would it be possible to hide installed extensions from the 'add new channels' list? Eg. if Google and Pinterest are installed then it shouldn't reappear as a suggested channel to be installed. |
Yup, that can be done, I'll do that. 🙂 👍
Yup, that is the plan, installed channels should not show up in the "add new channels" recommendation list. And if all the recommended channels are installed and there are no more recommended channels, then the "Add channels for other campaign types" section should not show up. |
@nima-karimi and I had a quick discussion about this (Slack DM: p1671648075729309-slack-D01D3A2V188). Currently we do not have the functionality to add campaigns in the backend, and it is a bit complicated to implement it. For the MVP, we are focusing on showing the campaigns, so we will put "campaign creation" functionality aside for future iteration. |
…paigns-card' into feature/34903-multichannel-marketing-frontend/34909-create-campaign-modal Conflicts: plugins/woocommerce-admin/client/marketing/hooks/index.ts plugins/woocommerce-admin/client/marketing/overview-multichannel/Campaigns/Campaigns.tsx plugins/woocommerce-admin/client/marketing/overview-multichannel/Channels/Channels.tsx plugins/woocommerce-admin/client/marketing/overview-multichannel/Channels/RecommendedChannels.tsx plugins/woocommerce-admin/client/marketing/overview-multichannel/Channels/useChannels.ts
Closing this PR in favor of PR #37044, because I want to change the branch name and to merge the changes into trunk branch instead of feature branch. |
All Submissions:
Changes proposed in this Pull Request:
Part of #34909.
This PR implements the "Create a new campaign" modal.
The implemented modal here is different from the figma designs in #34909. Specifically, there are no borders within the modal component. This is to be more consistent with the WordPress Modal component which no longer has border under the modal title since PR WordPress/gutenberg#40781.
How to test the changes in this Pull Request:
Pre-conditions: Enable WooCommerce Multichannel Marketing experience in WooCommerce Settings > Advanced > Features page:
/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=features
/wp-admin/admin.php?page=wc-admin&path=%2Fmarketing
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: